From 579dcf0601b01dc5e411e32a933c54968eb9c65e Mon Sep 17 00:00:00 2001 From: yidong0635 Date: Tue, 7 Dec 2021 16:10:19 +0800 Subject: [PATCH] scripts/rpc : Add required notice for TRSVCID. As we known, there's a bug in argparser, which puts required descriptions in optional list. There are many such descriptions, if not to break a lot of existing scripts, just adding a notice description behind required item. Signed-off-by: yidong0635 Change-Id: I3d8d2db96dc947d8342cc4e04ce3914da64be146 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10580 Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Paul Luse Reviewed-by: Maciej Szwed Reviewed-by: Changpeng Liu Reviewed-by: Tomasz Zawadzki --- scripts/rpc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/rpc.py b/scripts/rpc.py index 5003d6644..656a25c6d 100755 --- a/scripts/rpc.py +++ b/scripts/rpc.py @@ -2064,7 +2064,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse p.add_argument('-a', '--traddr', help='NVMe-oF transport address: e.g., an ip address', required=True) p.add_argument('-p', '--tgt-name', help='The name of the parent NVMe-oF target (optional)', type=str) p.add_argument('-f', '--adrfam', help='NVMe-oF transport adrfam: e.g., ipv4, ipv6, ib, fc, intra_host') - p.add_argument('-s', '--trsvcid', help='NVMe-oF transport service id: e.g., a port number') + p.add_argument('-s', '--trsvcid', help='NVMe-oF transport service id: e.g., a port number (required for TCP and RDMA transport types)') p.set_defaults(func=nvmf_subsystem_remove_listener) def nvmf_subsystem_listener_set_ana_state(args):