From 574af757ca048e75a2b59a4b501e30a8c44fe1db Mon Sep 17 00:00:00 2001 From: Maciej Szwed Date: Tue, 21 Nov 2017 12:19:33 +0100 Subject: [PATCH] lvol: fix lvol store examine when no lvols present When there are no lvols present on lvol store spdk_bdev_module_examine_done function is not called when tasting is done. Signed-off-by: Maciej Szwed Change-Id: Ia6c559f392148e3b4444dbc547df462bbe02356d Reviewed-on: https://review.gerrithub.io/388402 Tested-by: SPDK Automated Test System Reviewed-by: Daniel Verkamp Reviewed-by: Jim Harris Signed-off-by: Tomasz Zawadzki Reviewed-on: https://review.gerrithub.io/388587 Reviewed-by: Dariusz Stojaczyk --- lib/bdev/lvol/vbdev_lvol.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/bdev/lvol/vbdev_lvol.c b/lib/bdev/lvol/vbdev_lvol.c index 9581c65c8..70db0b76b 100644 --- a/lib/bdev/lvol/vbdev_lvol.c +++ b/lib/bdev/lvol/vbdev_lvol.c @@ -848,9 +848,14 @@ _vbdev_lvs_examine_cb(void *arg, struct spdk_lvol_store *lvol_store, int lvserrn lvol_store->lvols_opened = 0; - /* Open all lvols */ - TAILQ_FOREACH_SAFE(lvol, &lvol_store->lvols, link, tmp) { - spdk_lvol_open(lvol, _vbdev_lvs_examine_finish, lvol_store); + if (TAILQ_EMPTY(&lvol_store->lvols)) { + SPDK_INFOLOG(SPDK_TRACE_VBDEV_LVOL, "Lvol store examination done\n"); + spdk_bdev_module_examine_done(SPDK_GET_BDEV_MODULE(lvol)); + } else { + /* Open all lvols */ + TAILQ_FOREACH_SAFE(lvol, &lvol_store->lvols, link, tmp) { + spdk_lvol_open(lvol, _vbdev_lvs_examine_finish, lvol_store); + } } end: