From 5717784633a2fd5f8993fcb3951cc2366cfb8606 Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Tue, 22 Sep 2015 16:35:12 -0700 Subject: [PATCH] nvme: assert that tracker's request is valid In nvme_qpair_complete_tracker, make sure we got a valid request in the tracker that is being completed. This should never occur in practice, but safeguard against it in case of programmer error. Fixes a scan-build warning about potential NULL dereference. Change-Id: Id82af604d2a5ed5de0aeccf3affa1900f6712ebe Signed-off-by: Daniel Verkamp --- lib/nvme/nvme_qpair.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/nvme/nvme_qpair.c b/lib/nvme/nvme_qpair.c index 597704a1a..b39711ad2 100644 --- a/lib/nvme/nvme_qpair.c +++ b/lib/nvme/nvme_qpair.c @@ -298,6 +298,9 @@ nvme_qpair_complete_tracker(struct nvme_qpair *qpair, struct nvme_tracker *tr, bool retry, error; req = tr->req; + + nvme_assert(req != NULL, ("tr has NULL req\n")); + error = nvme_completion_is_error(cpl); retry = error && nvme_completion_is_retry(cpl) && req->retries < nvme_retry_count;