From 54fb60177a459d8e35aac76c44b016b8bfd2ee19 Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Thu, 30 Nov 2017 11:34:00 -0700 Subject: [PATCH] lvol: clean up includes in lvol.h All SPDK public API headers should include spdk/stdinc.h first. Additionally, the other headers included in lvol.h aren't needed; spdk/queue.h was unused, and spdk/blob.h can be replaced with a forward declaration of struct spdk_bs_dev. Change-Id: I89fad764efbb4c088ce325392f8237c1a869a895 Signed-off-by: Daniel Verkamp Reviewed-on: https://review.gerrithub.io/389895 Reviewed-by: Jim Harris Reviewed-by: Maciej Szwed Tested-by: SPDK Automated Test System Reviewed-by: Ben Walker --- include/spdk/lvol.h | 4 ++-- include/spdk_internal/lvolstore.h | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/spdk/lvol.h b/include/spdk/lvol.h index e2b72287a..5b5d63bca 100644 --- a/include/spdk/lvol.h +++ b/include/spdk/lvol.h @@ -38,9 +38,9 @@ #ifndef SPDK_LVOL_H #define SPDK_LVOL_H -#include "spdk/queue.h" -#include "spdk/blob.h" +#include "spdk/stdinc.h" +struct spdk_bs_dev; struct spdk_lvol_store; struct spdk_lvol; diff --git a/include/spdk_internal/lvolstore.h b/include/spdk_internal/lvolstore.h index 9eee8510e..4474c5077 100644 --- a/include/spdk_internal/lvolstore.h +++ b/include/spdk_internal/lvolstore.h @@ -34,6 +34,7 @@ #ifndef SPDK_INTERNAL_LVOLSTORE_H #define SPDK_INTERNAL_LVOLSTORE_H +#include "spdk/blob.h" #include "spdk/lvol.h" #include "spdk_internal/bdev.h"