ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ut/bdev_nvme: Separate disconnected and connected qpair in poll_group

Browse Source 
More precise stubs for spdk_nvme_poll_group are critically important
to verify upcoming changes.

Add a flag is_failed to struct spdk_nvme_qpair separately from
is_connected. This is used to inject error to a connection.

Replace a single list qpairs by two lists, connected_qpairs and
disconnected_qpairs for struct spdk_nvme_poll_group.

Then utilize these to manage qpair in poll group.

spdk_nvme_ctrlr_reconnect_io_qpair() is not used in the NVMe bdev
module now. Remove the corresponding stub.

Adjust polling count accordingly.

Change-Id: I4d867c56ae518276813f6f96d23a5f6933364fd4
Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10816
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Shuhei Matsumoto 2021-12-20 21:04:18 +09:00 committed by Tomasz Zawadzki
parent 34eea269f5
commit 5485f55dc1
1 changed files with 73 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

103
test/unit/lib/bdev/nvme/bdev_nvme.c/bdev_nvme_ut.c
View File

@ -231,11 +231,13 @@ struct spdk_nvme_ns {
struct spdk_nvme_qpair { struct spdk_nvme_qpair {
struct spdk_nvme_ctrlr *ctrlr; struct spdk_nvme_ctrlr *ctrlr;
bool is_failed;
bool is_connected; bool is_connected;
TAILQ_HEAD(, ut_nvme_req) outstanding_reqs; TAILQ_HEAD(, ut_nvme_req) outstanding_reqs;
uint32_t num_outstanding_reqs; uint32_t num_outstanding_reqs;
TAILQ_ENTRY(spdk_nvme_qpair) poll_group_tailq; TAILQ_ENTRY(spdk_nvme_qpair) poll_group_tailq;
struct spdk_nvme_poll_group *poll_group; struct spdk_nvme_poll_group *poll_group;
void *poll_group_tailq_head;
TAILQ_ENTRY(spdk_nvme_qpair) tailq; TAILQ_ENTRY(spdk_nvme_qpair) tailq;
}; };
@ -257,7 +259,8 @@ struct spdk_nvme_ctrlr {
struct spdk_nvme_poll_group { struct spdk_nvme_poll_group {
void *ctx; void *ctx;
struct spdk_nvme_accel_fn_table accel_fn_table; struct spdk_nvme_accel_fn_table accel_fn_table;
TAILQ_HEAD(, spdk_nvme_qpair) qpairs; TAILQ_HEAD(, spdk_nvme_qpair) connected_qpairs;
TAILQ_HEAD(, spdk_nvme_qpair) disconnected_qpairs;
}; };
struct spdk_nvme_probe_ctx { struct spdk_nvme_probe_ctx {
@ -674,6 +677,30 @@ spdk_nvme_ctrlr_alloc_io_qpair(struct spdk_nvme_ctrlr *ctrlr,
return qpair; return qpair;
} }
static void
nvme_poll_group_connect_qpair(struct spdk_nvme_qpair *qpair)
{
struct spdk_nvme_poll_group *group = qpair->poll_group;
CU_ASSERT(qpair->poll_group_tailq_head == &group->disconnected_qpairs);
qpair->poll_group_tailq_head = &group->connected_qpairs;
TAILQ_REMOVE(&group->disconnected_qpairs, qpair, poll_group_tailq);
TAILQ_INSERT_TAIL(&group->connected_qpairs, qpair, poll_group_tailq);
}
static void
nvme_poll_group_disconnect_qpair(struct spdk_nvme_qpair *qpair)
{
struct spdk_nvme_poll_group *group = qpair->poll_group;
CU_ASSERT(qpair->poll_group_tailq_head == &group->connected_qpairs);
qpair->poll_group_tailq_head = &group->disconnected_qpairs;
TAILQ_REMOVE(&group->connected_qpairs, qpair, poll_group_tailq);
TAILQ_INSERT_TAIL(&group->disconnected_qpairs, qpair, poll_group_tailq);
}
int int
spdk_nvme_ctrlr_connect_io_qpair(struct spdk_nvme_ctrlr *ctrlr, spdk_nvme_ctrlr_connect_io_qpair(struct spdk_nvme_ctrlr *ctrlr,
struct spdk_nvme_qpair *qpair) struct spdk_nvme_qpair *qpair)
@ -684,20 +711,9 @@ spdk_nvme_ctrlr_connect_io_qpair(struct spdk_nvme_ctrlr *ctrlr,
qpair->is_connected = true; qpair->is_connected = true;
return 0; if (qpair->poll_group) {
} nvme_poll_group_connect_qpair(qpair);
int
spdk_nvme_ctrlr_reconnect_io_qpair(struct spdk_nvme_qpair *qpair)
{
struct spdk_nvme_ctrlr *ctrlr;
ctrlr = qpair->ctrlr;
if (ctrlr->is_failed) {
return -ENXIO;
} }
qpair->is_connected = true;
return 0; return 0;
} }
@ -705,7 +721,16 @@ spdk_nvme_ctrlr_reconnect_io_qpair(struct spdk_nvme_qpair *qpair)
void void
spdk_nvme_ctrlr_disconnect_io_qpair(struct spdk_nvme_qpair *qpair) spdk_nvme_ctrlr_disconnect_io_qpair(struct spdk_nvme_qpair *qpair)
{ {
if (!qpair->is_connected) {
return;
}
qpair->is_failed = false;
qpair->is_connected = false; qpair->is_connected = false;
if (qpair->poll_group != NULL) {
nvme_poll_group_disconnect_qpair(qpair);
}
} }
int int
@ -713,7 +738,7 @@ spdk_nvme_ctrlr_free_io_qpair(struct spdk_nvme_qpair *qpair)
{ {
SPDK_CU_ASSERT_FATAL(qpair->ctrlr != NULL); SPDK_CU_ASSERT_FATAL(qpair->ctrlr != NULL);
qpair->is_connected = false; spdk_nvme_ctrlr_disconnect_io_qpair(qpair);
if (qpair->poll_group != NULL) { if (qpair->poll_group != NULL) {
spdk_nvme_poll_group_remove(qpair->poll_group, qpair); spdk_nvme_poll_group_remove(qpair->poll_group, qpair);
@ -1026,7 +1051,8 @@ spdk_nvme_poll_group_create(void *ctx, struct spdk_nvme_accel_fn_table *table)
if (table != NULL) { if (table != NULL) {
group->accel_fn_table = *table; group->accel_fn_table = *table;
} }
TAILQ_INIT(&group->qpairs); TAILQ_INIT(&group->connected_qpairs);
TAILQ_INIT(&group->disconnected_qpairs);
return group; return group;
} }
@ -1034,7 +1060,8 @@ spdk_nvme_poll_group_create(void *ctx, struct spdk_nvme_accel_fn_table *table)
int int
spdk_nvme_poll_group_destroy(struct spdk_nvme_poll_group *group) spdk_nvme_poll_group_destroy(struct spdk_nvme_poll_group *group)
{ {
if (!TAILQ_EMPTY(&group->qpairs)) { if (!TAILQ_EMPTY(&group->connected_qpairs) ||
!TAILQ_EMPTY(&group->disconnected_qpairs)) {
return -EBUSY; return -EBUSY;
} }
@ -1077,8 +1104,16 @@ spdk_nvme_poll_group_process_completions(struct spdk_nvme_poll_group *group,
return -EINVAL; return -EINVAL;
} }
TAILQ_FOREACH_SAFE(qpair, &group->qpairs, poll_group_tailq, tmp_qpair) { TAILQ_FOREACH_SAFE(qpair, &group->disconnected_qpairs, poll_group_tailq, tmp_qpair) {
if (qpair->is_connected) { disconnected_qpair_cb(qpair, group->ctx);
}
TAILQ_FOREACH_SAFE(qpair, &group->connected_qpairs, poll_group_tailq, tmp_qpair) {
if (qpair->is_failed) {
spdk_nvme_ctrlr_disconnect_io_qpair(qpair);
continue;
}
local_completions = spdk_nvme_qpair_process_completions(qpair, local_completions = spdk_nvme_qpair_process_completions(qpair,
completions_per_qpair); completions_per_qpair);
if (local_completions < 0 && error_reason == 0) { if (local_completions < 0 && error_reason == 0) {
@ -1088,13 +1123,6 @@ spdk_nvme_poll_group_process_completions(struct spdk_nvme_poll_group *group,
assert(num_completions >= 0); assert(num_completions >= 0);
} }
} }
}
TAILQ_FOREACH_SAFE(qpair, &group->qpairs, poll_group_tailq, tmp_qpair) {
if (!qpair->is_connected) {
disconnected_qpair_cb(qpair, group->ctx);
}
}
return error_reason ? error_reason : num_completions; return error_reason ? error_reason : num_completions;
} }
@ -1106,7 +1134,8 @@ spdk_nvme_poll_group_add(struct spdk_nvme_poll_group *group,
CU_ASSERT(!qpair->is_connected); CU_ASSERT(!qpair->is_connected);
qpair->poll_group = group; qpair->poll_group = group;
TAILQ_INSERT_TAIL(&group->qpairs, qpair, poll_group_tailq); qpair->poll_group_tailq_head = &group->disconnected_qpairs;
TAILQ_INSERT_TAIL(&group->disconnected_qpairs, qpair, poll_group_tailq);
return 0; return 0;
} }
@ -1116,8 +1145,12 @@ spdk_nvme_poll_group_remove(struct spdk_nvme_poll_group *group,
struct spdk_nvme_qpair *qpair) struct spdk_nvme_qpair *qpair)
{ {
CU_ASSERT(!qpair->is_connected); CU_ASSERT(!qpair->is_connected);
CU_ASSERT(qpair->poll_group_tailq_head == &group->disconnected_qpairs);
TAILQ_REMOVE(&group->qpairs, qpair, poll_group_tailq); TAILQ_REMOVE(&group->disconnected_qpairs, qpair, poll_group_tailq);
qpair->poll_group = NULL;
qpair->poll_group_tailq_head = NULL;
return 0; return 0;
} }
@ -2526,7 +2559,7 @@ test_abort(void)
* the corresponding nvme_ctrlr. I/O should be queued if it is submitted * the corresponding nvme_ctrlr. I/O should be queued if it is submitted
* while resetting the nvme_ctrlr. * while resetting the nvme_ctrlr.
*/ */
ctrlr_ch1->qpair->is_connected = false; ctrlr_ch1->qpair->is_failed = true;
poll_thread_times(0, 3); poll_thread_times(0, 3);
@ -2898,10 +2931,10 @@ test_reconnect_qpair(void)
/* If a qpair is disconnected, it is freed and then reconnected via /* If a qpair is disconnected, it is freed and then reconnected via
* resetting the corresponding nvme_ctrlr. * resetting the corresponding nvme_ctrlr.
*/ */
ctrlr_ch2->qpair->is_connected = false; ctrlr_ch2->qpair->is_failed = true;
ctrlr->is_failed = true; ctrlr->is_failed = true;
poll_thread_times(1, 1); poll_thread_times(1, 2);
CU_ASSERT(ctrlr_ch1->qpair != NULL); CU_ASSERT(ctrlr_ch1->qpair != NULL);
CU_ASSERT(ctrlr_ch2->qpair == NULL); CU_ASSERT(ctrlr_ch2->qpair == NULL);
CU_ASSERT(nvme_ctrlr->resetting == true); CU_ASSERT(nvme_ctrlr->resetting == true);
@ -2931,11 +2964,11 @@ test_reconnect_qpair(void)
/* If a qpair is disconnected and resetting the corresponding nvme_ctrlr /* If a qpair is disconnected and resetting the corresponding nvme_ctrlr
* fails, the qpair is just freed. * fails, the qpair is just freed.
*/ */
ctrlr_ch2->qpair->is_connected = false; ctrlr_ch2->qpair->is_failed = true;
ctrlr->is_failed = true; ctrlr->is_failed = true;
ctrlr->fail_reset = true; ctrlr->fail_reset = true;
poll_thread_times(1, 1); poll_thread_times(1, 2);
CU_ASSERT(ctrlr_ch1->qpair != NULL); CU_ASSERT(ctrlr_ch1->qpair != NULL);
CU_ASSERT(ctrlr_ch2->qpair == NULL); CU_ASSERT(ctrlr_ch2->qpair == NULL);
CU_ASSERT(nvme_ctrlr->resetting == true); CU_ASSERT(nvme_ctrlr->resetting == true);
@ -5080,10 +5113,10 @@ test_retry_io_if_ctrlr_is_resetting(void)
* the corresponding nvme_ctrlr. I/O should be queued if it is submitted * the corresponding nvme_ctrlr. I/O should be queued if it is submitted
* while resetting the nvme_ctrlr. * while resetting the nvme_ctrlr.
*/ */
ctrlr_ch->qpair->is_connected = false; ctrlr_ch->qpair->is_failed = true;
ctrlr->is_failed = true; ctrlr->is_failed = true;
poll_thread_times(0, 4); poll_thread_times(0, 5);
CU_ASSERT(ctrlr_ch->qpair == NULL); CU_ASSERT(ctrlr_ch->qpair == NULL);
CU_ASSERT(nvme_ctrlr->resetting == true); CU_ASSERT(nvme_ctrlr->resetting == true);