ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test/iscsi: Change the order of delete_bdev to fix nightly test failure.

Browse Source 
By the following change, delete bdev operation will wait until all
related iSCSI connections exit.

    scsi: Don't free IO channel at LUN removal not by allocator

Hence delete bdev must be called after iscsicleanup in test code.

The following patch tried to do that. However nightly test code was
missed to change.

    test/iscsi: Change the order of delete_bdev that hides uncorrect
    hotplug implementation.

This patch fixes the failure of nightly test. By this patch passing
iSCSI nightly test was verified.

Change-Id: Ia3ac234db6d569212de9234b7201b132236b5993
Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/417376
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Shuhei Matsumoto 2018-06-30 15:26:06 +09:00 committed by Jim Harris
parent f04277f0bf
commit 546a114847
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/iscsi_tgt/ext4test/ext4test.sh
View File

@ -113,12 +113,11 @@ for dev in $devs; do
echo ""
done
$rpc_py delete_error_bdev EE_Malloc0
trap - SIGINT SIGTERM EXIT
rm -f $testdir/iscsi.conf
iscsicleanup
$rpc_py delete_error_bdev EE_Malloc0
killprocess $pid
report_test_completion "nightly_iscsi_ext4test"
timing_exit ext4test