From 5412468f874d19bc6c015ed011414367f9311529 Mon Sep 17 00:00:00 2001 From: Shuhei Matsumoto Date: Wed, 25 Dec 2019 19:30:24 -0500 Subject: [PATCH] bdevperf: Use negative errno to pass bdevperf_fini() or rpc_perform_tests_cb() bdevperf_fini() had expected to get one but rpc_perform_tests_cb() had expected to get negative errno for any error. Using negative errno will be reasonable and change the code accordingly. The next patch will unify local rc variables and the global g_run_failed by changing g_run_failed to g_run_errno. Signed-off-by: Shuhei Matsumoto Change-Id: Ia43da0793f8e77a5d5491758589e9b77f4cf86e7 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/478832 Tested-by: SPDK CI Jenkins Community-CI: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Ben Walker --- test/bdev/bdevperf/bdevperf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/bdev/bdevperf/bdevperf.c b/test/bdev/bdevperf/bdevperf.c index 84a2d20bc..2a64cca4b 100644 --- a/test/bdev/bdevperf/bdevperf.c +++ b/test/bdev/bdevperf/bdevperf.c @@ -471,7 +471,7 @@ end_run(void *arg1, void *arg2) } if (g_run_failed) { - rc = 1; + rc = -1; } if (g_request && !g_shutdown) { @@ -1308,7 +1308,7 @@ bdevperf_run(void *arg1) rc = blockdev_heads_init(); if (rc) { - spdk_app_stop(1); + spdk_app_stop(rc); return; } @@ -1323,7 +1323,7 @@ bdevperf_run(void *arg1) rc = bdevperf_test(); if (rc) { - bdevperf_fini(1); + bdevperf_fini(rc); return; } }