From 538cbe7b3dec3fb7610c780cf5139f98eafc6bcf Mon Sep 17 00:00:00 2001 From: Karol Latecki Date: Wed, 31 Jul 2019 16:04:56 +0200 Subject: [PATCH] test/vhost: replace backtick command calls with dollar-parentheses Fix shellcheck styling error SC2006. Use of backtics is deprecated and dollar-parentheses are encouraged instead. Removing SC2006 from check_format.sh error exlusion list. Change-Id: I8ef9d782839ff4361386720c39a28e449b5efab9 Signed-off-by: Karol Latecki Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/463801 Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris Reviewed-by: Tomasz Zawadzki --- scripts/check_format.sh | 2 +- test/vhost/fuzz/fuzz.sh | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/check_format.sh b/scripts/check_format.sh index 4dc195e54..df4ca7800 100755 --- a/scripts/check_format.sh +++ b/scripts/check_format.sh @@ -240,7 +240,7 @@ if hash shellcheck 2>/dev/null; then # go to: https://trello.com/c/29Z90j1W # Error descriptions can also be found at: https://github.com/koalaman/shellcheck/wiki SHCK_EXCLUDE="SC1001,SC1003,SC1004,SC1009,SC1010,SC1019,SC1020,SC1072,SC1073,\ -SC1083,SC1087,SC1090,SC1091,SC1113,SC2001,SC2002,SC2003,SC2004,SC2005,SC2006,\ +SC1083,SC1087,SC1090,SC1091,SC1113,SC2001,SC2002,SC2003,SC2004,SC2005,\ SC2007,SC2009,SC2010,SC2012,SC2013,SC2015,SC2016,SC2018,SC2019,SC2022,SC2026,\ SC2027,SC2030,SC2031,SC2034,SC2035,SC2039,SC2043,SC2044,SC2045,SC2046,SC2048,\ SC2059,SC2064,SC2068,SC2070,SC2074,SC2086,SC2088,SC2089,SC2090,SC2091,SC2094,\ diff --git a/test/vhost/fuzz/fuzz.sh b/test/vhost/fuzz/fuzz.sh index e29f4bae8..f3dbaa6a8 100755 --- a/test/vhost/fuzz/fuzz.sh +++ b/test/vhost/fuzz/fuzz.sh @@ -39,11 +39,11 @@ $vhost_rpc_py construct_vhost_scsi_controller naa.VhostScsi0.2 $vhost_rpc_py add_vhost_scsi_lun naa.VhostScsi0.2 0 Malloc2 # test the vhost blk controller with valid data buffers. -$fuzz_specific_rpc_py fuzz_vhost_create_dev -s `pwd`/Vhost.1 -b -v +$fuzz_specific_rpc_py fuzz_vhost_create_dev -s $(pwd)/Vhost.1 -b -v # test the vhost scsi I/O queue with valid data buffers on a valid lun. -$fuzz_specific_rpc_py fuzz_vhost_create_dev -s `pwd`/naa.VhostScsi0.1 -l -v +$fuzz_specific_rpc_py fuzz_vhost_create_dev -s $(pwd)/naa.VhostScsi0.1 -l -v # test the vhost scsi management queue with valid data buffers. -$fuzz_specific_rpc_py fuzz_vhost_create_dev -s `pwd`/naa.VhostScsi0.2 -v -m +$fuzz_specific_rpc_py fuzz_vhost_create_dev -s $(pwd)/naa.VhostScsi0.2 -v -m # The test won't actually begin until this option is passed in. $fuzz_generic_rpc_py start_subsystem_init @@ -56,9 +56,9 @@ waitforlisten $fuzzpid $FUZZ_RPC_SOCK # re-evaluate fuzzpid trap "killprocess $vhostpid; killprocess $fuzzpid; exit 1" SIGINT SIGTERM exit -$fuzz_specific_rpc_py fuzz_vhost_create_dev -s `pwd`/Vhost.1 -b -v -$fuzz_specific_rpc_py fuzz_vhost_create_dev -s `pwd`/naa.VhostScsi0.1 -l -v -$fuzz_specific_rpc_py fuzz_vhost_create_dev -s `pwd`/naa.VhostScsi0.2 -v -m +$fuzz_specific_rpc_py fuzz_vhost_create_dev -s $(pwd)/Vhost.1 -b -v +$fuzz_specific_rpc_py fuzz_vhost_create_dev -s $(pwd)/naa.VhostScsi0.1 -l -v +$fuzz_specific_rpc_py fuzz_vhost_create_dev -s $(pwd)/naa.VhostScsi0.2 -v -m $fuzz_generic_rpc_py start_subsystem_init wait $fuzzpid