From 535466d7cd5dcdfabe5f7ef83cf62a8701b48554 Mon Sep 17 00:00:00 2001 From: Pawel Wodkowski Date: Mon, 29 Oct 2018 16:17:31 +0100 Subject: [PATCH] mk: set executable bit only for real libraries Change-Id: I9f68f83472844cabe6a36f70a00f2d2cd319fc62 Signed-off-by: Pawel Wodkowski Reviewed-on: https://review.gerrithub.io/431169 Reviewed-by: Seth Howell Reviewed-by: Lance Hartmann Reviewed-by: Ben Walker Reviewed-by: Jim Harris Tested-by: SPDK CI Jenkins Chandler-Test-Pool: SPDK Automated Test System --- mk/spdk.common.mk | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mk/spdk.common.mk b/mk/spdk.common.mk index 3612551c7..b00e8edc2 100644 --- a/mk/spdk.common.mk +++ b/mk/spdk.common.mk @@ -273,7 +273,12 @@ endef INSTALL_SHARED_LIB=\ $(Q)echo " INSTALL $(DESTDIR)$(libdir)/$(notdir $(SHARED_LINKED_LIB))"; \ install -d -m 755 "$(DESTDIR)$(libdir)"; \ - install -m 755 "$(SHARED_REALNAME_LIB)" "$(DESTDIR)$(libdir)/"; \ + if file --mime-type $(SHARED_REALNAME_LIB) | grep -q 'application/x-sharedlib'; then \ + perm_mode=755; \ + else \ + perm_mode=644; \ + fi; \ + install -m $$perm_mode "$(SHARED_REALNAME_LIB)" "$(DESTDIR)$(libdir)/"; \ $(call spdk_install_lib_symlink,$(notdir $(SHARED_REALNAME_LIB)),$(notdir $(SHARED_LINKED_LIB))); # Install an app binary