From 5282edfd7bae6f4d1b450e28c2f8a596e284e69f Mon Sep 17 00:00:00 2001 From: Alexey Marchuk Date: Tue, 16 Jul 2019 05:50:16 +0000 Subject: [PATCH] rdma: fix double free of qpair struct in case of failed initialization qpair structure is freed and an error code is returned to the caller in the case of failed qpair initialization in function spdk_nvmf_rdma_qpair_initialize (e.g. bad return value of rdma_create_qp). The return code is handled by nvmf_tgt_poll_group_add function which destroys the qpair for the second time. This patch fixes #857 Change-Id: I0773652ecccbbd634ad272106e0a93c1e591d7d2 Signed-off-by: Alexey Marchuk Signed-off-by: Sasha Kotchubievsky Signed-off-by: Evgenii Kochetov Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462011 Reviewed-by: Darek Stojaczyk Reviewed-by: Shuhei Matsumoto Reviewed-by: Lorne Li Reviewed-by: Ben Walker Tested-by: SPDK CI Jenkins --- lib/nvmf/rdma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/nvmf/rdma.c b/lib/nvmf/rdma.c index a5824ec15..2b98dc99a 100644 --- a/lib/nvmf/rdma.c +++ b/lib/nvmf/rdma.c @@ -1039,7 +1039,6 @@ spdk_nvmf_rdma_qpair_initialize(struct spdk_nvmf_qpair *qpair) error: rdma_destroy_id(rqpair->cm_id); rqpair->cm_id = NULL; - spdk_nvmf_rdma_qpair_destroy(rqpair); return -1; }