ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rpmbuild: Fix Requires section

Browse Source 
This particular section must be defined in one place hence the
%{requirements_list} cannot be passed down later on. This requires
reordering of the .spec a bit. Most notably, all global macros are
now defined at the very beginning so then Requires section can be
build properly.

Also, use %() to expand the macro which holds the requirements as
bare "Requires: %{foo}" is not valid.

Signed-off-by: Michal Berger <michalx.berger@intel.com>
Change-Id: I69430f73d10204325fc825ecc392506f261ebaf1
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8347
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Michal Berger 2021-06-15 18:57:36 +02:00 committed by Jim Harris
parent f5cb018a92
commit 52652c30cb
1 changed files with 20 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
rpmbuild/spdk.spec
View File

@ -1,20 +1,4 @@
Name: spdk # Global macros
Version: %{version}
Release: %{release}
Summary: Storage Performance Development Kit
License: BSD
URL: https://spdk.io
Source: spdk-%{version}.tar.gz
%description
The Storage Performance Development Kit (SPDK) provides a set of tools and libraries for
writing high performance, scalable, user-mode storage applications. It achieves high
performance by moving all of the necessary drivers into userspace and operating in a
polled mode instead of relying on interrupts, which avoids kernel context switches and
eliminates interrupt handling overhead.
%define debug_package %{nil} %define debug_package %{nil}
%{!?deps:%define deps 1} %{!?deps:%define deps 1}
@ -24,6 +8,12 @@ eliminates interrupt handling overhead.
%{!?requirements:%define requirements 0} %{!?requirements:%define requirements 0}
%{!?shared:%define shared 0} %{!?shared:%define shared 0}
# Spec metadata
Name: spdk
Version: %{version}
Release: %{release}
Summary: Storage Performance Development Kit
# This is a minimal set of requirements needed for SPDK apps to run when built with # This is a minimal set of requirements needed for SPDK apps to run when built with
# default configuration. These are also predetermined by rpmbuild. Extra requirements # default configuration. These are also predetermined by rpmbuild. Extra requirements
# can be defined through a comma-separated list passed via $requirements when building # can be defined through a comma-separated list passed via $requirements when building
@ -39,9 +29,21 @@ Requires: openssl-libs
Requires: zlib Requires: zlib
%if %{requirements} %if %{requirements}
Requires: %{requirements_list} Requires: %(echo "%{requirements_list}")
%endif %endif
License: BSD
URL: https://spdk.io
Source: spdk-%{version}.tar.gz
%description
The Storage Performance Development Kit (SPDK) provides a set of tools and libraries for
writing high performance, scalable, user-mode storage applications. It achieves high
performance by moving all of the necessary drivers into userspace and operating in a
polled mode instead of relying on interrupts, which avoids kernel context switches and
eliminates interrupt handling overhead.
%prep %prep
make clean &>/dev/null || : make clean &>/dev/null || :
%setup %setup