From 51bc5fce791967e06bd89a4b2f019284b3eea2c9 Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Wed, 20 Jul 2016 09:34:49 -0700 Subject: [PATCH] nvmf: drop redundant response CID assignments spdk_nvmf_request_complete() always sets CID to the value in the command, so there is no need to set it in the command execution functions. Change-Id: Ibbe745b862e27fff7c55e553758ef093e3ef7f6d Signed-off-by: Daniel Verkamp --- lib/nvmf/request.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/nvmf/request.c b/lib/nvmf/request.c index 4fed08a7b..0d33a544f 100644 --- a/lib/nvmf/request.c +++ b/lib/nvmf/request.c @@ -78,7 +78,6 @@ nvmf_process_discovery_cmd(struct spdk_nvmf_request *req) /* pre-set response details for this command */ response->status.sc = SPDK_NVME_SC_SUCCESS; - response->cid = cmd->cid; if (req->data == NULL) { SPDK_ERRLOG("discovery command with no buffer\n"); @@ -151,7 +150,6 @@ nvmf_process_admin_cmd(struct spdk_nvmf_request *req) /* pre-set response details for this command */ response->status.sc = SPDK_NVME_SC_SUCCESS; - response->cid = cmd->cid; switch (cmd->opc) { case SPDK_NVME_OPC_IDENTIFY: @@ -266,7 +264,6 @@ nvmf_process_io_cmd(struct spdk_nvmf_request *req) /* pre-set response details for this command */ response = &req->rsp->nvme_cpl; response->status.sc = SPDK_NVME_SC_SUCCESS; - response->cid = cmd->cid; /* verify that the contoller is ready to process commands */ if (session->vcprop.csts.bits.rdy == 0) {