From 5066e52d631156a2bb51d06e784fe14bb9749b67 Mon Sep 17 00:00:00 2001 From: GangCao Date: Mon, 26 Jun 2017 18:07:51 -0400 Subject: [PATCH] nvme: subnqn is case sensitive and update the unit test Change-Id: I43337b4a51cb2008737ed9a9691707a9bfb04c5c Signed-off-by: GangCao Reviewed-on: https://review.gerrithub.io/367146 Tested-by: SPDK Automated Test System Reviewed-by: Daniel Verkamp Reviewed-by: Ben Walker --- test/unit/lib/nvme/nvme.c/nvme_ut.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/test/unit/lib/nvme/nvme.c/nvme_ut.c b/test/unit/lib/nvme/nvme.c/nvme_ut.c index 6bc36ecb3..c3a6062bf 100644 --- a/test/unit/lib/nvme/nvme.c/nvme_ut.c +++ b/test/unit/lib/nvme/nvme.c/nvme_ut.c @@ -312,6 +312,18 @@ test_trid_parse_and_compare(void) ret = spdk_nvme_transport_id_compare(&trid1, &trid2); CU_ASSERT(ret < 0); + memset_trid(&trid1, &trid2); + snprintf(trid1.subnqn, sizeof(trid1.subnqn), "subnqn:nqn.2016-08.org.nvmexpress.discovery"); + snprintf(trid2.subnqn, sizeof(trid2.subnqn), "subnqn:nqn.2016-08.org.nvmexpress.discovery"); + ret = spdk_nvme_transport_id_compare(&trid1, &trid2); + CU_ASSERT(ret == 0); + + memset_trid(&trid1, &trid2); + snprintf(trid1.subnqn, sizeof(trid1.subnqn), "subnqn:nqn.2016-08.org.nvmexpress.discovery"); + snprintf(trid2.subnqn, sizeof(trid2.subnqn), "subnqn:nqn.2016-08.org.Nvmexpress.discovery"); + ret = spdk_nvme_transport_id_compare(&trid1, &trid2); + CU_ASSERT(ret > 0); + memset_trid(&trid1, &trid2); ret = spdk_nvme_transport_id_compare(&trid1, &trid2); CU_ASSERT(ret == 0);