From 5017a67fdc05ad181c0a48fb294762ec38a2a876 Mon Sep 17 00:00:00 2001 From: Pawel Kaminski Date: Mon, 9 Sep 2019 11:06:48 -0400 Subject: [PATCH] test: Shellcheck - apply rule SC2191 The = here is literal. To assign by index, use ( [index]=value ) with no spaces. To keep as literal, quote it. Change-Id: I14cada0e8c132286959aa47a1d37ede5e025d85f Signed-off-by: Pawel Kaminski Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/467863 Tested-by: SPDK CI Jenkins Reviewed-by: Paul Luse Reviewed-by: Karol Latecki Reviewed-by: Jim Harris Reviewed-by: Ben Walker --- scripts/check_format.sh | 2 +- test/common/config/vm_setup.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/check_format.sh b/scripts/check_format.sh index e68de2955..bb88c99f1 100755 --- a/scripts/check_format.sh +++ b/scripts/check_format.sh @@ -246,7 +246,7 @@ SC2027,SC2030,SC2031,SC2034,SC2035,SC2039,SC2043,SC2044,SC2045,SC2046,SC2048,\ SC2059,SC2068,SC2074,SC2086,SC2088,SC2089,SC2090,SC2091,SC2094,\ SC2097,SC2098,SC2103,SC2115,SC2116,SC2119,SC2120,SC2121,SC2124,SC2126,SC2128,\ SC2129,SC2140,SC2142,SC2143,SC2145,SC2146,SC2148,SC2152,SC2153,SC2154,SC2155,\ -SC2162,SC2164,SC2165,SC2166,SC2167,SC2174,SC2178,SC2181,SC2191,\ +SC2162,SC2164,SC2165,SC2166,SC2167,SC2174,SC2178,SC2181,\ SC2206,SC2207,SC2214,SC2223,SC2230,SC2231,SC2235" # SPDK fails some error checks which have been deprecated in later versions of shellcheck. # We will not try to fix these error checks, but instead just leave the error types here diff --git a/test/common/config/vm_setup.sh b/test/common/config/vm_setup.sh index 9fe22da0d..ea9dc3b5b 100755 --- a/test/common/config/vm_setup.sh +++ b/test/common/config/vm_setup.sh @@ -228,7 +228,7 @@ function install_qemu() # If using tsocks, please make sure to complete this config before trying to build qemu. if echo $CONF | grep -q tsocks; then if hash tsocks 2> /dev/null; then - opt_params+=(--with-git='tsocks git') + opt_params+=("--with-git='tsocks git'") fi fi