From 4faa7b58378392b1d1975bc0721e66ae2e96ec25 Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Thu, 26 Mar 2020 09:36:50 -0400 Subject: [PATCH] test: remove RUN_NIGHTLY_FAILING flag Purpose of this flag is sketchy at best. Failing tests should be either fixed or disabled/removed. Running separate job in hopes of it fixing itself, might not bring the expected outcome. Case in point - test case in this patch was added to this flag over a year ago. This is last remaining test case under this flag. So there is no need for it to exist. Signed-off-by: Tomasz Zawadzki Change-Id: I8481ac7102245889047dde083b34276d22271a03 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1495 Tested-by: SPDK CI Jenkins Reviewed-by: Karol Latecki Reviewed-by: Jim Harris Reviewed-by: Shuhei Matsumoto --- test/bdev/blockdev.sh | 8 +------- test/common/autotest_common.sh | 3 --- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/test/bdev/blockdev.sh b/test/bdev/blockdev.sh index 348d3a5b8..43c93cf1f 100755 --- a/test/bdev/blockdev.sh +++ b/test/bdev/blockdev.sh @@ -192,13 +192,7 @@ function fio_test_suite() { echo "filename=$b" >> $testdir/bdev.fio done - if [ $RUN_NIGHTLY_FAILING -eq 0 ]; then - local fio_params="--ioengine=spdk_bdev --iodepth=8 --bs=4k --runtime=10 $testdir/bdev.fio --spdk_json_conf=$conf_file" - else - # Use size 192KB which both exceeds typical 128KB max NVMe I/O - # size and will cross 128KB Intel DC P3700 stripe boundaries. - local fio_params="--ioengine=spdk_bdev --iodepth=128 --bs=192k --runtime=100 $testdir/bdev.fio --spdk_json_conf=$conf_file" - fi + local fio_params="--ioengine=spdk_bdev --iodepth=8 --bs=4k --runtime=10 $testdir/bdev.fio --spdk_json_conf=$conf_file" run_test "bdev_fio_rw_verify" fio_bdev $fio_params --spdk_mem=$PRE_RESERVED_MEM \ --output=$output_dir/blockdev_fio_verify.txt diff --git a/test/common/autotest_common.sh b/test/common/autotest_common.sh index c3b276152..81b22115d 100755 --- a/test/common/autotest_common.sh +++ b/test/common/autotest_common.sh @@ -54,9 +54,6 @@ fi' : ${RUN_NIGHTLY:=0} export RUN_NIGHTLY -: ${RUN_NIGHTLY_FAILING:=0} -export RUN_NIGHTLY_FAILING - # Set defaults for missing test config options : ${SPDK_AUTOTEST_DEBUG_APPS:=0}; export SPDK_AUTOTEST_DEBUG_APPS : ${SPDK_BUILD_PACKAGE=0}; export SPDK_BUILD_PACKAGE