From 4ef6d0f934787c9e300ff36317502d272fa27d20 Mon Sep 17 00:00:00 2001 From: Paul Luse Date: Tue, 25 Jul 2017 14:38:50 -0700 Subject: [PATCH] fio_plugin: stop specifying io_queue_size in the probe_cb() This will cause the NVMe driver to use the default qpair size as opposed to setting it up for the first job in what may end being a series of jobs in the same fio config file. If we don't do this and subsequent jobs are specifying a higher queue depth than earlier jobs, the NVMe qpairs will be too small and performance results can be way off. Future fix logged on Trello to correctly size q pairs even when multiple jobs are specified in a single file but this is a small optimization. Change-Id: I73a7b83b10418dd22b663a50ea8e33a6c3d7ecf7 Signed-off-by: Paul Luse Reviewed-on: https://review.gerrithub.io/371240 Tested-by: SPDK Automated Test System Reviewed-by: Daniel Verkamp Reviewed-by: Ben Walker Reviewed-by: Jim Harris --- examples/nvme/fio_plugin/fio_plugin.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/examples/nvme/fio_plugin/fio_plugin.c b/examples/nvme/fio_plugin/fio_plugin.c index 3e324c77b..bd302fe58 100644 --- a/examples/nvme/fio_plugin/fio_plugin.c +++ b/examples/nvme/fio_plugin/fio_plugin.c @@ -92,10 +92,6 @@ static bool probe_cb(void *cb_ctx, const struct spdk_nvme_transport_id *trid, struct spdk_nvme_ctrlr_opts *opts) { - struct thread_data *td = (struct thread_data *)cb_ctx; - - opts->io_queue_size = td->o.iodepth + 1; - return true; }