From 4d6ff5a86839bf8798533db8beec0d3a51c0c5f3 Mon Sep 17 00:00:00 2001 From: Pawel Kaminski Date: Mon, 23 Sep 2019 05:32:23 -0400 Subject: [PATCH] test: Shellcheck - remove rule SC2231 from exception list There was no occurrences in code that doesn't meet this rule SC2231: Quote expansions in this for loop glob to prevent wordsplitting, e.g. "$dir"/*.txt . Change-Id: I9293459dd6bea401f675a7af379db25f48664f25 Signed-off-by: Pawel Kaminski Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/469106 Tested-by: SPDK CI Jenkins Reviewed-by: Karol Latecki Reviewed-by: Maciej Wawryk Reviewed-by: Ben Walker Reviewed-by: Jim Harris --- scripts/check_format.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/check_format.sh b/scripts/check_format.sh index edb94de03..e602222c9 100755 --- a/scripts/check_format.sh +++ b/scripts/check_format.sh @@ -248,7 +248,7 @@ SC2068,SC2086,SC2089,SC2090,\ SC2097,SC2098,SC2103,SC2115,SC2116,SC2119,SC2120,SC2121,SC2124,SC2126,SC2128,\ SC2129,SC2140,SC2142,SC2143,SC2145,SC2146,SC2148,SC2152,SC2153,SC2154,SC2155,\ SC2162,SC2164,SC2165,SC2166,SC2167,SC2174,\ -SC2206,SC2207,SC2230,SC2231" +SC2206,SC2207,SC2230" # SPDK fails some error checks which have been deprecated in later versions of shellcheck. # We will not try to fix these error checks, but instead just leave the error types here # so that we can still run with older versions of shellcheck.