From 4c13df5116c2200aed98c08e9031d7f895ed75e7 Mon Sep 17 00:00:00 2001 From: Pawel Kaminski Date: Tue, 3 Sep 2019 16:08:01 -0400 Subject: [PATCH] test: Shellcheck - apply rule SC2214 This case is not specified by getopts. Change-Id: Id292af4f926856af849d2f97fd0a570e4505832b Signed-off-by: Pawel Kaminski Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/467288 Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Shuhei Matsumoto --- scripts/check_format.sh | 2 +- scripts/gen_ftl.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/check_format.sh b/scripts/check_format.sh index 611052a6d..dc5b7ac25 100755 --- a/scripts/check_format.sh +++ b/scripts/check_format.sh @@ -248,7 +248,7 @@ SC2068,SC2086,SC2089,SC2090,\ SC2097,SC2098,SC2103,SC2115,SC2116,SC2119,SC2120,SC2121,SC2124,SC2126,SC2128,\ SC2129,SC2140,SC2142,SC2143,SC2145,SC2146,SC2148,SC2152,SC2153,SC2154,SC2155,\ SC2162,SC2164,SC2165,SC2166,SC2167,SC2174,\ -SC2206,SC2207,SC2214,SC2223,SC2230,SC2231" +SC2206,SC2207,SC2223,SC2230,SC2231" # SPDK fails some error checks which have been deprecated in later versions of shellcheck. # We will not try to fix these error checks, but instead just leave the error types here # so that we can still run with older versions of shellcheck. diff --git a/scripts/gen_ftl.sh b/scripts/gen_ftl.sh index 064840d3a..c68634ca7 100755 --- a/scripts/gen_ftl.sh +++ b/scripts/gen_ftl.sh @@ -47,7 +47,7 @@ function create_json_config() uuid=00000000-0000-0000-0000-000000000000 -while getopts "ja:n:l:m:u:c:" arg; do +while getopts "ja:n:l:m:u:c:h" arg; do case "$arg" in j) json=1 ;; a) addr=$OPTARG ;;