From 4b428979856c80f0324ae808ff1dedd79eed19d5 Mon Sep 17 00:00:00 2001 From: Dariusz Stojaczyk Date: Tue, 23 Jan 2018 14:23:00 +0100 Subject: [PATCH] setup.sh: fix chown Patch da7e3bb8 [1] disabled chown for vfio groups and hugepage mountpoints. Chown code was never being executed. [1] da7e3bb8 ("setup.sh: replace username param with TARGET_USER env variable") Change-Id: Ie5c9ac42fca5b60c72ced501d4065842a5bef9cd Signed-off-by: Dariusz Stojaczyk Reviewed-on: https://review.gerrithub.io/395925 Tested-by: SPDK Automated Test System Reviewed-by: Daniel Verkamp Reviewed-by: Ben Walker --- scripts/setup.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/setup.sh b/scripts/setup.sh index a10a7fa53..c4c61b7ee 100755 --- a/scripts/setup.sh +++ b/scripts/setup.sh @@ -84,7 +84,7 @@ function linux_bind_driver() { iommu_group=$(basename $(readlink -f /sys/bus/pci/devices/$bdf/iommu_group)) if [ -e "/dev/vfio/$iommu_group" ]; then - if [ -z "$TARGET_USER" ]; then + if [ -n "$TARGET_USER" ]; then chown "$TARGET_USER" "/dev/vfio/$iommu_group" fi fi @@ -237,7 +237,7 @@ function configure_linux { fi if [ "$driver_name" = "vfio-pci" ]; then - if [ -z "$TARGET_USER" ]; then + if [ -n "$TARGET_USER" ]; then chown "$TARGET_USER" "$hugetlbfs_mount" chmod g+w "$hugetlbfs_mount" fi