ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

blobstore: change _spdk_bs_blob_list_remove() type to void

Browse Source 
_spdk_bs_blob_list_remove function returns only 0
so it can be changed to void function.

Signed-off-by: Maciej Szwed <maciej.szwed@intel.com>
Change-Id: I1827d783a7cd18caf831275554e33f398b0b962f

Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/451783
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Maciej Szwed 2019-04-23 19:57:44 +02:00 committed by Jim Harris
parent 58c4dac9d9
commit 4b1012d5bf
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/blob/blobstore.c
View File

@ -2374,7 +2374,7 @@ _spdk_bs_blob_list_add(struct spdk_blob *blob)
return 0; return 0;
} }
static int static void
_spdk_bs_blob_list_remove(struct spdk_blob *blob) _spdk_bs_blob_list_remove(struct spdk_blob *blob)
{ {
struct spdk_blob_list *snapshot_entry = NULL; struct spdk_blob_list *snapshot_entry = NULL;
@ -2383,7 +2383,7 @@ _spdk_bs_blob_list_remove(struct spdk_blob *blob)
_spdk_blob_get_snapshot_and_clone_entries(blob, &snapshot_entry, &clone_entry); _spdk_blob_get_snapshot_and_clone_entries(blob, &snapshot_entry, &clone_entry);
if (snapshot_entry == NULL) { if (snapshot_entry == NULL) {
return 0; return;
} }
blob->parent_id = SPDK_BLOBID_INVALID; blob->parent_id = SPDK_BLOBID_INVALID;
@ -2391,8 +2391,6 @@ _spdk_bs_blob_list_remove(struct spdk_blob *blob)
free(clone_entry); free(clone_entry);
snapshot_entry->clone_count--; snapshot_entry->clone_count--;
return 0;
} }
static int static int
@ -5085,12 +5083,7 @@ _spdk_bs_delete_open_cpl(void *cb_arg, struct spdk_blob *blob, int bserrno)
} }
} }
bserrno = _spdk_bs_blob_list_remove(blob); _spdk_bs_blob_list_remove(blob);
if (bserrno != 0) {
SPDK_DEBUGLOG(SPDK_LOG_BLOB, "Remove blob #%" PRIu64 " from a list\n", blob->id);
spdk_bs_sequence_finish(seq, bserrno);
return;
}
if (blob->locked_operation_in_progress) { if (blob->locked_operation_in_progress) {
SPDK_DEBUGLOG(SPDK_LOG_BLOB, "Cannot remove blob - another operation in progress\n"); SPDK_DEBUGLOG(SPDK_LOG_BLOB, "Cannot remove blob - another operation in progress\n");