From 4a36aabd0cde7a4657f3bc8e16f91a01b6de2864 Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Mon, 16 May 2016 10:39:35 -0700 Subject: [PATCH] nvme_qpair: add sanity-check asserts to print_command Document the requirement that qpair and cmd can't be NULL. This placates clang, which previously generated a warning during scan-build. Change-Id: Ic2d5e808faee0028c890ce1312444fb3dc95f223 Signed-off-by: Daniel Verkamp --- lib/nvme/nvme_qpair.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/nvme/nvme_qpair.c b/lib/nvme/nvme_qpair.c index 663dfa44d..04deca1f0 100644 --- a/lib/nvme/nvme_qpair.c +++ b/lib/nvme/nvme_qpair.c @@ -115,7 +115,8 @@ static void nvme_io_qpair_print_command(struct spdk_nvme_qpair *qpair, struct spdk_nvme_cmd *cmd) { - + nvme_assert(qpair != NULL, ("print_command: qpair == NULL\n")); + nvme_assert(cmd != NULL, ("print_command: cmd == NULL\n")); switch ((int)cmd->opc) { case SPDK_NVME_OPC_WRITE: case SPDK_NVME_OPC_READ: