ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bdev/crypto: remove unnecessary driver init call on crypto dev hotplug

Browse Source 
The crypto drivers are now always initialized at
bdev module init, so any subsequent attempts to
init them would immediately return with rc = 0.

Besides, from the code perspective, this call does
not have the proper error handling. To clean up
all of this, we remove the call entirely.

Change-Id: I8e4f5a314b8c5e83a50c668d6c8953a95d6832cc
Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/430678
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
This commit is contained in:
Darek Stojaczyk 2018-10-25 06:48:22 +02:00 committed by Ben Walker
parent 010f723d3a
commit 49e9bfda9c
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/bdev/crypto/vbdev_crypto.c
View File

@ -1209,11 +1209,6 @@ create_crypto_disk(const char *bdev_name, const char *vbdev_name,
return rc;
}
rc = vbdev_crypto_init_crypto_drivers();
if (rc) {
return rc;
}
TAILQ_FOREACH_SAFE(crypto_bdev, &g_vbdev_crypto, link, tmp) {
if (strcmp(crypto_bdev->base_bdev->name, bdev->name) == 0) {
rc = spdk_vbdev_register(&crypto_bdev->crypto_bdev,