From 46dd96c2f0f821a581b5d8344235c2fd5f0acd0c Mon Sep 17 00:00:00 2001 From: Seth Howell Date: Thu, 28 Feb 2019 07:02:24 -0700 Subject: [PATCH] rdma: update default number of shared buffers. When the decision was made to uncouple the number of shared buffers from the queue depth and allow the user to decide for themselves, the default was also significantly lowered, which caused some issues when trying torun performance tests (See https://github.com/spdk/spdk/issues/699). While this is a user modifiable variable, it is still best to keep the higher default value. The original value was equivalent to max_queue_depth * SPDK_NVMF_MAX_SGL_ENTRIES * 2 with the defaults for max_queue depth and max_sgl_entries being 128 and 16 respectively. Hence 4096 fixes: 0b20f2e552d978d84780e0ab968bb7fa65f7707e Change-Id: I809e97a10973093a2b485b85bca7160091166f70 Signed-off-by: Seth Howell Reviewed-on: https://review.gerrithub.io/c/446525 (master) Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/447465 Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker --- lib/nvmf/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/nvmf/rdma.c b/lib/nvmf/rdma.c index 4e768e3ce..87714f710 100644 --- a/lib/nvmf/rdma.c +++ b/lib/nvmf/rdma.c @@ -1703,7 +1703,7 @@ spdk_nvmf_rdma_request_process(struct spdk_nvmf_rdma_transport *rtransport, #define SPDK_NVMF_RDMA_DEFAULT_IN_CAPSULE_DATA_SIZE 4096 #define SPDK_NVMF_RDMA_DEFAULT_MAX_IO_SIZE 131072 #define SPDK_NVMF_RDMA_MIN_IO_BUFFER_SIZE (SPDK_NVMF_RDMA_DEFAULT_MAX_IO_SIZE / SPDK_NVMF_MAX_SGL_ENTRIES) -#define SPDK_NVMF_RDMA_DEFAULT_NUM_SHARED_BUFFERS 512 +#define SPDK_NVMF_RDMA_DEFAULT_NUM_SHARED_BUFFERS 4096 #define SPDK_NVMF_RDMA_DEFAULT_BUFFER_CACHE_SIZE 32 static void