ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test/multipath: don't wait for bdevperf to finish

Browse Source 
After multipath tests are finished we were waiting up to 40s for
bdevperf to finish.  It doesn't test anything, besided the fact that we
can do IOs for 40s after changing to an optimized path.  To reduce test
time, simply kill bdevperf immediately after multipath tests are done.

There's no need to check the status of the perform_tests RPC, as we also
check bdevperf's exit status, so we're bound to catch errors anyway.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I73fee92c8bd65d780659332de7ddb5f68c5f14d1
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16665
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Michal Berger <michal.berger@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Konrad Sztyber 2023-02-02 12:54:05 +01:00 committed by Tomasz Zawadzki
parent 41b9487d2a
commit 461321cc26
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/nvmf/host/multipath.sh
View File

@ -74,7 +74,6 @@ function confirm_io_on_port() {
} }
"$rootdir/examples/bdev/bdevperf/bdevperf.py" -t 120 -s $bdevperf_rpc_sock perform_tests & "$rootdir/examples/bdev/bdevperf/bdevperf.py" -t 120 -s $bdevperf_rpc_sock perform_tests &
rpc_pid=$!
sleep 1 sleep 1
@ -112,10 +111,11 @@ $rpc_py nvmf_subsystem_listener_set_ana_state $NQN -t $TEST_TRANSPORT -a $NVMF_F
sleep 6 sleep 6
confirm_io_on_port "optimized" $NVMF_SECOND_PORT confirm_io_on_port "optimized" $NVMF_SECOND_PORT
wait $rpc_pid
cat "$testdir/try.txt"
killprocess $bdevperf_pid killprocess $bdevperf_pid
# Make sure we catch bdevperf's exit status
wait $bdevperf_pid
cat "$testdir/try.txt"
$rpc_py nvmf_delete_subsystem $NQN $rpc_py nvmf_delete_subsystem $NQN