From 437dce1a5bf2a15a7c5af327349ed526cf8ac0c4 Mon Sep 17 00:00:00 2001 From: Jim Harris Date: Tue, 5 Nov 2019 05:51:35 -0700 Subject: [PATCH] nvme/perf: remove unnecessary logging There's little use to the "Starting thread on core XX" messages - they may have served a purpose at some point, but the other messages showing where each controller is associated is sufficient. Also remove the "Attaching to..." message - the "Attached to..." message is sufficient here too. Signed-off-by: Jim Harris Change-Id: I9543e8f3f6d7b6e28238cba27fc1e4194908f3b7 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/473337 Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Shuhei Matsumoto Reviewed-by: Alexey Marchuk --- examples/nvme/perf/perf.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/examples/nvme/perf/perf.c b/examples/nvme/perf/perf.c index 585badc88..511c83400 100644 --- a/examples/nvme/perf/perf.c +++ b/examples/nvme/perf/perf.c @@ -1017,8 +1017,6 @@ work_fn(void *arg) struct ns_worker_ctx *ns_ctx = NULL; uint32_t unfinished_ns_ctx; - printf("Starting thread on core %u\n", worker->lcore); - /* Allocate queue pairs for each namespace. */ ns_ctx = worker->ns_ctx; while (ns_ctx != NULL) { @@ -1812,20 +1810,13 @@ static bool probe_cb(void *cb_ctx, const struct spdk_nvme_transport_id *trid, struct spdk_nvme_ctrlr_opts *opts) { - if (trid->trtype != SPDK_NVME_TRANSPORT_PCIE) { - printf("Attaching to NVMe over Fabrics controller at %s:%s: %s\n", - trid->traddr, trid->trsvcid, - trid->subnqn); - } else { + if (trid->trtype == SPDK_NVME_TRANSPORT_PCIE) { if (g_disable_sq_cmb) { opts->use_cmb_sqs = false; } if (g_no_shn_notification) { opts->no_shn_notification = true; } - - printf("Attaching to NVMe Controller at %s\n", - trid->traddr); } /* Set io_queue_size to UINT16_MAX, NVMe driver