From 425b89a4edc7a3db2d87ae35de3f4c962dc64eec Mon Sep 17 00:00:00 2001 From: yidong0635 Date: Fri, 19 Jul 2019 11:53:16 -0400 Subject: [PATCH] compress: Fix scanbuild error about dereference of null pointer. Issue reports: vbdev_compress.c:468:34: warning: Dereference of null pointer src_mbufs[iov_index]->userdata = reduce_cb_arg; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~ Add assert here is enough. Change-Id: I8dccf107a89f7af46437a1f678adccf122beb4b2 Signed-off-by: yidong0635 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462592 Reviewed-by: Darek Stojaczyk Reviewed-by: Changpeng Liu Tested-by: SPDK CI Jenkins --- lib/bdev/compress/vbdev_compress.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/bdev/compress/vbdev_compress.c b/lib/bdev/compress/vbdev_compress.c index 583ff4120..767117857 100644 --- a/lib/bdev/compress/vbdev_compress.c +++ b/lib/bdev/compress/vbdev_compress.c @@ -470,6 +470,7 @@ _compress_operation(struct spdk_reduce_backing_dev *backing_dev, struct iovec *s current_src_iov = src_iovs[iov_index].iov_base; total_length += src_iovs[iov_index].iov_len; + assert(src_mbufs[iov_index] != NULL); src_mbufs[iov_index]->userdata = reduce_cb_arg; rte_pktmbuf_attach_extbuf(src_mbufs[iov_index],