ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ioat: change return type of spdk_ioat_detach() to be void

Browse Source 
The method spdk_ioat_detach() never fails. This patch changes its
return type to be void instead of int.

Change-Id: I6f5bda9ab330c02ae0535bed8b78d416c7b1e264
Signed-off-by: Rami Rosen <ramirose@gmail.com>
Reviewed-on: https://review.gerrithub.io/425252
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Seth Howell <seth.howell5141@gmail.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
Rami Rosen 2018-09-11 14:58:05 +03:00 committed by Jim Harris
parent 55014ddf53
commit 412d89cd6f
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/spdk/ioat.h
View File

@ -104,10 +104,8 @@ int spdk_ioat_probe(void *cb_ctx, spdk_ioat_probe_cb probe_cb, spdk_ioat_attach_
* Detach specified device returned by spdk_ioat_probe() from the I/OAT driver. * Detach specified device returned by spdk_ioat_probe() from the I/OAT driver.
* *
* \param ioat I/OAT channel to detach from the driver. * \param ioat I/OAT channel to detach from the driver.
*
* \return 0 on success.
*/ */
int spdk_ioat_detach(struct spdk_ioat_chan *ioat); void spdk_ioat_detach(struct spdk_ioat_chan *ioat);
/** /**
* Submit a DMA engine memory copy request. * Submit a DMA engine memory copy request.

4
lib/ioat/ioat.c
View File

@ -568,7 +568,7 @@ spdk_ioat_probe(void *cb_ctx, spdk_ioat_probe_cb probe_cb, spdk_ioat_attach_cb a
return rc; return rc;
} }
int void
spdk_ioat_detach(struct spdk_ioat_chan *ioat) spdk_ioat_detach(struct spdk_ioat_chan *ioat)
{ {
struct ioat_driver *driver = &g_ioat_driver; struct ioat_driver *driver = &g_ioat_driver;
@ -582,8 +582,6 @@ spdk_ioat_detach(struct spdk_ioat_chan *ioat)
ioat_channel_destruct(ioat); ioat_channel_destruct(ioat);
free(ioat); free(ioat);
return 0;
} }
#define _2MB_PAGE(ptr) ((ptr) & ~(0x200000 - 1)) #define _2MB_PAGE(ptr) ((ptr) & ~(0x200000 - 1))