From 4121477d918b9fd252d9beb60e5a6677b7a89235 Mon Sep 17 00:00:00 2001 From: Konrad Sztyber Date: Fri, 25 Oct 2019 12:33:01 +0200 Subject: [PATCH] lib/vmd: make sure pcie_cap is not NULL before dereferencing it Fixes #1006 Change-Id: I761e1cbb49c09318a8d2eda9b4a2ee0bcdcebc37 Signed-off-by: Konrad Sztyber Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/472385 Tested-by: SPDK CI Jenkins Reviewed-by: Maciej Wawryk Reviewed-by: Tomasz Zawadzki Reviewed-by: Jim Harris Reviewed-by: Ziye Yang --- lib/vmd/vmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vmd/vmd.c b/lib/vmd/vmd.c index 62f023153..e4b90f2cf 100644 --- a/lib/vmd/vmd.c +++ b/lib/vmd/vmd.c @@ -869,7 +869,7 @@ vmd_scan_single_bus(struct vmd_pci_bus *bus, struct vmd_pci_device *parent_bridg new_bus->self = new_dev; new_dev->bus_object = new_bus; - if (slot_cap.bit_field.hotplug_capable && + if (slot_cap.bit_field.hotplug_capable && new_dev->pcie_cap != NULL && new_dev->pcie_cap->express_cap_register.bit_field.slot_implemented) { new_bus->hotplug_buses = vmd_get_hotplug_bus_numbers(new_dev); new_bus->subordinate_bus += new_bus->hotplug_buses;