From 40ef8b34b7006a60953897976d202a2f991a9c1f Mon Sep 17 00:00:00 2001 From: Ben Walker Date: Fri, 31 Jan 2020 10:16:53 -0700 Subject: [PATCH] nvmf: Don't typedef enum in nvmf_cmd.h This isn't SPDK's coding style. Change-Id: Ifedfd7823b45302d40031589f39bfa60e0f4dfbb Signed-off-by: Ben Walker Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/414 Reviewed-by: Jim Harris Reviewed-by: Shuhei Matsumoto Reviewed-by: Aleksey Marchuk Reviewed-by: Michael Haeuptle Tested-by: SPDK CI Jenkins --- include/spdk/nvmf_cmd.h | 4 ++-- lib/nvmf/ctrlr.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/spdk/nvmf_cmd.h b/include/spdk/nvmf_cmd.h index 1afedadf2..97d7541eb 100644 --- a/include/spdk/nvmf_cmd.h +++ b/include/spdk/nvmf_cmd.h @@ -39,10 +39,10 @@ #include "spdk/nvmf_transport.h" #include "spdk/bdev.h" -typedef enum _spdk_nvmf_request_exec_status { +enum spdk_nvmf_request_exec_status { SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE, SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS, -} spdk_nvmf_request_exec_status; +}; int spdk_nvmf_ctrlr_identify_ctrlr(struct spdk_nvmf_ctrlr *ctrlr, struct spdk_nvme_ctrlr_data *cdata); diff --git a/lib/nvmf/ctrlr.c b/lib/nvmf/ctrlr.c index 67f647c4e..2f3d54296 100644 --- a/lib/nvmf/ctrlr.c +++ b/lib/nvmf/ctrlr.c @@ -2753,7 +2753,7 @@ _nvmf_request_exec(struct spdk_nvmf_request *req, struct spdk_nvmf_subsystem_poll_group *sgroup) { struct spdk_nvmf_qpair *qpair = req->qpair; - spdk_nvmf_request_exec_status status; + enum spdk_nvmf_request_exec_status status; nvmf_trace_command(req->cmd, spdk_nvmf_qpair_is_admin_queue(qpair));