ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

blobcli: Improve error check of input parsing by spdk_strtol

Browse Source 
It looks that each call of atoi expects atoi returns negative
for any error. spdk_strtol will satisfy this requirement.

Change-Id: Ic21817499ed280ef4b26809ab311f337c2636470
Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/c/441627
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: wuzhouhui <wuzhouhui@kingsoft.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
This commit is contained in:
Shuhei Matsumoto 2019-01-23 08:46:11 +09:00 committed by Jim Harris
parent b78e763c1a
commit 404c5a3fd0
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
examples/blob/cli/blobcli.c
View File

@ -1081,7 +1081,7 @@ cmd_parser(int argc, char **argv, struct cli_context_t *cli_context)
cmd_chosen++; cmd_chosen++;
cli_context->action = CLI_FILL; cli_context->action = CLI_FILL;
cli_context->blobid = atoll(optarg); cli_context->blobid = atoll(optarg);
cli_context->fill_value = atoi(argv[optind]); cli_context->fill_value = spdk_strtol(argv[optind], 10);
} else { } else {
usage(cli_context, "ERROR: missing parameter.\n"); usage(cli_context, "ERROR: missing parameter.\n");
} }
@ -1141,7 +1141,7 @@ cmd_parser(int argc, char **argv, struct cli_context_t *cli_context)
} }
break; break;
case 'n': case 'n':
cli_context->num_clusters = atoi(optarg); cli_context->num_clusters = spdk_strtol(optarg, 10);
if (cli_context->num_clusters > 0) { if (cli_context->num_clusters > 0) {
cmd_chosen++; cmd_chosen++;
cli_context->action = CLI_CREATE_BLOB; cli_context->action = CLI_CREATE_BLOB;
@ -1251,7 +1251,7 @@ line_parser(struct cli_context_t *cli_context)
cli_context->argv[cli_context->argc] = strdup(tok); cli_context->argv[cli_context->argc] = strdup(tok);
if (tok[0] == '$' && tok[1] == 'B') { if (tok[0] == '$' && tok[1] == 'B') {
tok += 2; tok += 2;
blob_num = atoi(tok); blob_num = spdk_strtol(tok, 10);
if (blob_num >= 0 && blob_num < MAX_SCRIPT_BLOBS) { if (blob_num >= 0 && blob_num < MAX_SCRIPT_BLOBS) {
cli_context->argv[cli_context->argc] = cli_context->argv[cli_context->argc] =
realloc(cli_context->argv[cli_context->argc], BUFSIZE); realloc(cli_context->argv[cli_context->argc], BUFSIZE);