From 40319c0e77e1ca01b3e8fb6547e4962004f02879 Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Fri, 3 Jun 2022 15:10:35 +0200 Subject: [PATCH] app: every app should have an (un)install target make install should install all apps. Signed-off-by: Heinrich Schuchardt Change-Id: I66c2f4536cb9f4c5bae1895066be2836038c0672 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12901 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Konrad Sztyber Reviewed-by: Ben Walker Reviewed-by: Paul Luse --- app/iscsi_tgt/Makefile | 6 ++++++ app/iscsi_top/Makefile | 6 ++++++ app/nvmf_tgt/Makefile | 6 ++++++ app/spdk_dd/Makefile | 6 ++++++ app/spdk_lspci/Makefile | 6 ++++++ app/spdk_top/Makefile | 6 ++++++ app/trace/Makefile | 6 ++++++ app/trace_record/Makefile | 6 ++++++ app/vhost/Makefile | 6 ++++++ 9 files changed, 54 insertions(+) diff --git a/app/iscsi_tgt/Makefile b/app/iscsi_tgt/Makefile index 5c42f89e5..58482c1ab 100644 --- a/app/iscsi_tgt/Makefile +++ b/app/iscsi_tgt/Makefile @@ -26,3 +26,9 @@ SPDK_LIB_LIST += event_nbd endif include $(SPDK_ROOT_DIR)/mk/spdk.app.mk + +install: $(APP) + $(INSTALL_APP) + +uninstall: + $(UNINSTALL_APP) diff --git a/app/iscsi_top/Makefile b/app/iscsi_top/Makefile index bd73a6821..601920fe8 100644 --- a/app/iscsi_top/Makefile +++ b/app/iscsi_top/Makefile @@ -16,3 +16,9 @@ CFLAGS += -I$(SPDK_ROOT_DIR)/lib C_SRCS := iscsi_top.c include $(SPDK_ROOT_DIR)/mk/spdk.app.mk + +install: $(APP) + $(INSTALL_APP) + +uninstall: + $(UNINSTALL_APP) diff --git a/app/nvmf_tgt/Makefile b/app/nvmf_tgt/Makefile index 9e69b4b08..2fe47b296 100644 --- a/app/nvmf_tgt/Makefile +++ b/app/nvmf_tgt/Makefile @@ -22,3 +22,9 @@ SPDK_LIB_LIST += event_nbd endif include $(SPDK_ROOT_DIR)/mk/spdk.app.mk + +install: $(APP) + $(INSTALL_APP) + +uninstall: + $(UNINSTALL_APP) diff --git a/app/spdk_dd/Makefile b/app/spdk_dd/Makefile index c2ac49845..6e0e07754 100644 --- a/app/spdk_dd/Makefile +++ b/app/spdk_dd/Makefile @@ -14,3 +14,9 @@ C_SRCS := spdk_dd.c SPDK_LIB_LIST = $(ALL_MODULES_LIST) event event_bdev include $(SPDK_ROOT_DIR)/mk/spdk.app.mk + +install: $(APP) + $(INSTALL_APP) + +uninstall: + $(UNINSTALL_APP) diff --git a/app/spdk_lspci/Makefile b/app/spdk_lspci/Makefile index 7c95408ae..c18bf1ea6 100644 --- a/app/spdk_lspci/Makefile +++ b/app/spdk_lspci/Makefile @@ -14,3 +14,9 @@ C_SRCS := spdk_lspci.c SPDK_LIB_LIST = $(SOCK_MODULES_LIST) nvme vmd include $(SPDK_ROOT_DIR)/mk/spdk.app.mk + +install: $(APP) + $(INSTALL_APP) + +uninstall: + $(UNINSTALL_APP) diff --git a/app/spdk_top/Makefile b/app/spdk_top/Makefile index fc34f5a87..e9d77a7f5 100644 --- a/app/spdk_top/Makefile +++ b/app/spdk_top/Makefile @@ -14,3 +14,9 @@ SPDK_LIB_LIST = rpc LIBS=-lpanel -lmenu -lncurses include $(SPDK_ROOT_DIR)/mk/spdk.app.mk + +install: $(APP) + $(INSTALL_APP) + +uninstall: + $(UNINSTALL_APP) diff --git a/app/trace/Makefile b/app/trace/Makefile index c174d9f96..65d75ca9f 100644 --- a/app/trace/Makefile +++ b/app/trace/Makefile @@ -15,3 +15,9 @@ SPDK_LIB_LIST += json trace_parser CXX_SRCS := trace.cpp include $(SPDK_ROOT_DIR)/mk/spdk.app_cxx.mk + +install: $(APP) + $(INSTALL_APP) + +uninstall: + $(UNINSTALL_APP) diff --git a/app/trace_record/Makefile b/app/trace_record/Makefile index f12cd2c79..718ea3eba 100644 --- a/app/trace_record/Makefile +++ b/app/trace_record/Makefile @@ -13,3 +13,9 @@ APP = spdk_trace_record C_SRCS := trace_record.c include $(SPDK_ROOT_DIR)/mk/spdk.app.mk + +install: $(APP) + $(INSTALL_APP) + +uninstall: + $(UNINSTALL_APP) diff --git a/app/vhost/Makefile b/app/vhost/Makefile index d3e7fb00e..934b464f8 100644 --- a/app/vhost/Makefile +++ b/app/vhost/Makefile @@ -18,3 +18,9 @@ SPDK_LIB_LIST += env_dpdk_rpc endif include $(SPDK_ROOT_DIR)/mk/spdk.app.mk + +install: $(APP) + $(INSTALL_APP) + +uninstall: + $(UNINSTALL_APP)