From 3edf1e200e27166b9c424bc2780078259184cc53 Mon Sep 17 00:00:00 2001 From: Ben Walker Date: Thu, 10 Feb 2022 15:20:12 -0700 Subject: [PATCH] test/bdev: In bdev_nvme_ut, handle spdk_nvme_poll_group_remove when there is no group The real implementation handles this by returning -ENOENT, so do the same in the test. Signed-off-by: Ben Walker Change-Id: I405b6f60bf4dcdb22c57e48bbaf66d57522a49c5 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11508 Community-CI: Mellanox Build Bot Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Jim Harris Reviewed-by: Michael Haeuptle --- test/unit/lib/bdev/nvme/bdev_nvme.c/bdev_nvme_ut.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/unit/lib/bdev/nvme/bdev_nvme.c/bdev_nvme_ut.c b/test/unit/lib/bdev/nvme/bdev_nvme.c/bdev_nvme_ut.c index 419f6b03a..565f35ecf 100644 --- a/test/unit/lib/bdev/nvme/bdev_nvme.c/bdev_nvme_ut.c +++ b/test/unit/lib/bdev/nvme/bdev_nvme.c/bdev_nvme_ut.c @@ -1183,6 +1183,11 @@ spdk_nvme_poll_group_remove(struct spdk_nvme_poll_group *group, struct spdk_nvme_qpair *qpair) { CU_ASSERT(!qpair->is_connected); + + if (qpair->poll_group == NULL) { + return -ENOENT; + } + CU_ASSERT(qpair->poll_group_tailq_head == &group->disconnected_qpairs); TAILQ_REMOVE(&group->disconnected_qpairs, qpair, poll_group_tailq);