From 3ecf99d65a2f1e6ce434baf901057f6ce6a79962 Mon Sep 17 00:00:00 2001 From: GangCao Date: Mon, 9 Jan 2023 02:38:45 -0500 Subject: [PATCH] app/spdk_top: check the valid pointer earlier Change-Id: I162d90257e7bf23cff9b9adc84b811f79c404da2 Signed-off-by: GangCao Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16178 Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Tomasz Zawadzki --- app/spdk_top/spdk_top.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/app/spdk_top/spdk_top.c b/app/spdk_top/spdk_top.c index f08f19c5a..e2f3d3caf 100644 --- a/app/spdk_top/spdk_top.c +++ b/app/spdk_top/spdk_top.c @@ -488,11 +488,8 @@ rpc_decode_cores_lw_threads(const struct spdk_json_val *val, void *out) * 'val' value (-2 is to subtract VAL_OBJECT_BEGIN/END). */ uint16_t threads_count = (spdk_json_val_len(val) - 2) / RPC_THREAD_ENTRY_SIZE; + assert(threads != NULL); threads->thread = calloc(threads_count, sizeof(struct rpc_core_thread_info)); - if (!out) { - fprintf(stderr, "Unable to allocate memory for a thread array.\n"); - return -1; - } return spdk_json_decode_array(val, rpc_decode_core_threads_object, threads->thread, threads_count, &threads->threads_count, sizeof(struct rpc_core_thread_info));