ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lib/idxd: update some func params for consistency

Browse Source 
Was using "dst" in some cases and "crc_dst" in others for crc32c
related calls.  Update them to always use crc_dst

Signed-off-by: paul luse <paul.e.luse@intel.com>
Change-Id: Icf200f1734c64c29881f23b02b8d12bad81b3ca0
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8186
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Ziye Yang <ziye.yang@intel.com>
This commit is contained in:
paul luse 2021-06-04 19:57:41 -04:00 committed by Jim Harris
parent 10808e45d4
commit 3bbfbb5b0f
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/spdk/idxd.h
View File

@ -352,7 +352,7 @@ int spdk_idxd_batch_prep_crc32c(struct spdk_idxd_io_channel *chan, struct idxd_b
* by writing to the proper device portal. * by writing to the proper device portal.
* *
* \param chan IDXD channel to submit request. * \param chan IDXD channel to submit request.
* \param dst Resulting calculation. * \param crc_dst Resulting calculation.
* \param src Source virtual address. * \param src Source virtual address.
* \param seed Four byte CRC-32C seed value. * \param seed Four byte CRC-32C seed value.
* \param nbytes Number of bytes to calculate on. * \param nbytes Number of bytes to calculate on.
@ -362,7 +362,7 @@ int spdk_idxd_batch_prep_crc32c(struct spdk_idxd_io_channel *chan, struct idxd_b
* *
* \return 0 on success, negative errno on failure. * \return 0 on success, negative errno on failure.
*/ */
int spdk_idxd_submit_crc32c(struct spdk_idxd_io_channel *chan, uint32_t *dst, void *src, int spdk_idxd_submit_crc32c(struct spdk_idxd_io_channel *chan, uint32_t *crc_dst, void *src,
uint32_t seed, uint64_t nbytes, uint32_t seed, uint64_t nbytes,
spdk_idxd_req_cb cb_fn, void *cb_arg); spdk_idxd_req_cb cb_fn, void *cb_arg);

4
lib/idxd/idxd.c
View File

@ -546,7 +546,7 @@ spdk_idxd_submit_fill(struct spdk_idxd_io_channel *chan, void *dst, uint64_t fil
} }
int int
spdk_idxd_submit_crc32c(struct spdk_idxd_io_channel *chan, uint32_t *dst, void *src, spdk_idxd_submit_crc32c(struct spdk_idxd_io_channel *chan, uint32_t *crc_dst, void *src,
uint32_t seed, uint64_t nbytes, uint32_t seed, uint64_t nbytes,
spdk_idxd_req_cb cb_fn, void *cb_arg) spdk_idxd_req_cb cb_fn, void *cb_arg)
{ {
@ -573,7 +573,7 @@ spdk_idxd_submit_crc32c(struct spdk_idxd_io_channel *chan, uint32_t *dst, void *
desc->flags &= IDXD_CLEAR_CRC_FLAGS; desc->flags &= IDXD_CLEAR_CRC_FLAGS;
desc->crc32c.seed = seed; desc->crc32c.seed = seed;
desc->xfer_size = nbytes; desc->xfer_size = nbytes;
comp->crc_dst = dst; comp->crc_dst = crc_dst;
/* Submit operation. */ /* Submit operation. */
movdir64b(chan->portal, desc); movdir64b(chan->portal, desc);