From 3ac9ba25f3435bcd9b79cd1a7f385d6ecee1f845 Mon Sep 17 00:00:00 2001
From: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Date: Fri, 31 Jan 2020 15:39:11 +0100
Subject: [PATCH] env_dpdk: fix potential null dereference

Change-Id: Iff5cfa780506191b3a7fb218c6b5948df2ac16a4
Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/523
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
---
 lib/env_dpdk/init.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/lib/env_dpdk/init.c b/lib/env_dpdk/init.c
index 2ea09cc77..6dae1a4c5 100644
--- a/lib/env_dpdk/init.c
+++ b/lib/env_dpdk/init.c
@@ -271,9 +271,13 @@ spdk_build_eal_cmdline(const struct spdk_env_opts *opts)
 	 */
 	if (opts->core_mask[0] == '[') {
 		char *l_arg = _sprintf_alloc("-l %s", opts->core_mask + 1);
-		int len = strlen(l_arg);
-		if (l_arg[len - 1] == ']') {
-			l_arg[len - 1] = '\0';
+
+		if (l_arg != NULL) {
+			int len = strlen(l_arg);
+
+			if (l_arg[len - 1] == ']') {
+				l_arg[len - 1] = '\0';
+			}
 		}
 		args = spdk_push_arg(args, &argcount, l_arg);
 	} else {