From 39c4f95b35d1dfaf4249e95ef44490a5ad4914b0 Mon Sep 17 00:00:00 2001 From: Ziye Yang Date: Tue, 12 Mar 2019 19:44:00 +0800 Subject: [PATCH] bdev: remove the unnecessary spdk_bdev_finish call. The calling of spdk_bdev_finish is in wrong place, the bdev subsystem recycling will be called by _spdk_subsystem_fini_next. If we call spdk_bdev_finish here, it will be called twice, so it is unnecessary. And this patch will be used to address the issue reported in: https://review.gerrithub.io/#/c/spdk/spdk/+/447613/ Change-Id: I03dff8b84bd0d7b49675ce8300b3da623963e140 Signed-off-by: Ziye Yang Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/447731 Reviewed-by: GangCao Reviewed-by: Shuhei Matsumoto Reviewed-by: Changpeng Liu Reviewed-by: Darek Stojaczyk Tested-by: SPDK CI Jenkins --- lib/bdev/bdev.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/lib/bdev/bdev.c b/lib/bdev/bdev.c index 626c5e645..19f0d7209 100644 --- a/lib/bdev/bdev.c +++ b/lib/bdev/bdev.c @@ -874,17 +874,10 @@ spdk_bdev_modules_init(void) return 0; } - -static void -spdk_bdev_init_failed_complete(void *cb_arg) -{ - spdk_bdev_init_complete(-1); -} - static void spdk_bdev_init_failed(void *cb_arg) { - spdk_bdev_finish(spdk_bdev_init_failed_complete, NULL); + spdk_bdev_init_complete(-1); } void