From 39068b6b5c28c0ee9ccd96090f1816ada7399e53 Mon Sep 17 00:00:00 2001 From: Shuhei Matsumoto Date: Tue, 11 Feb 2020 21:26:52 -0500 Subject: [PATCH] lib/iscsi: Fix a scan-build warning 1 warning generated. LIB libspdk_nvmf.a iscsi_subsystem.c:1285:25: warning: Result of 'calloc' is converted to a pointer of type 'struct spdk_iscsi_sess *', which is incompatible with sizeof operand type 'void *' g_spdk_iscsi.session = calloc(1, sizeof(void *) * g_spdk_iscsi.MaxSessions); ^~~~~~ ~~~~~~~~~~~~~ Signed-off-by: Shuhei Matsumoto Change-Id: Ieb8dcac8ec172405c5ca97a4867582ff9bfaa569 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/827 Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Tomasz Zawadzki --- lib/iscsi/iscsi_subsystem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/iscsi/iscsi_subsystem.c b/lib/iscsi/iscsi_subsystem.c index 6234e43b3..c3b0dd508 100644 --- a/lib/iscsi/iscsi_subsystem.c +++ b/lib/iscsi/iscsi_subsystem.c @@ -1322,7 +1322,7 @@ iscsi_parse_globals(void) return rc; } - g_spdk_iscsi.session = calloc(1, sizeof(void *) * g_spdk_iscsi.MaxSessions); + g_spdk_iscsi.session = calloc(1, sizeof(struct spdk_iscsi_sess *) * g_spdk_iscsi.MaxSessions); if (!g_spdk_iscsi.session) { SPDK_ERRLOG("calloc() failed for session array\n"); return -1;