From 38d75b56f4d47a651794bf6772620fbf8ad1bd03 Mon Sep 17 00:00:00 2001 From: Ben Walker Date: Mon, 9 Apr 2018 16:06:25 -0700 Subject: [PATCH] blobfs: Remove all uses of strncpy strncpy is going to be added to the list of banned functions because it does not guarantee strings are null terminated. Change-Id: I14e2ce65401bbdb77260627e94aa936797c20ce0 Signed-off-by: Ben Walker Reviewed-on: https://review.gerrithub.io/407020 Tested-by: SPDK Automated Test System Reviewed-by: Dariusz Stojaczyk Reviewed-by: Changpeng Liu Reviewed-by: Jim Harris --- lib/blobfs/blobfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/blobfs/blobfs.c b/lib/blobfs/blobfs.c index e1169498e..dbeef66a3 100644 --- a/lib/blobfs/blobfs.c +++ b/lib/blobfs/blobfs.c @@ -496,7 +496,7 @@ spdk_fs_init(struct spdk_bs_dev *dev, struct spdk_blobfs_opts *opt, args->fs = fs; spdk_bs_opts_init(&opts); - strncpy(opts.bstype.bstype, "BLOBFS", SPDK_BLOBSTORE_TYPE_LENGTH); + snprintf(opts.bstype.bstype, sizeof(opts.bstype.bstype), "BLOBFS"); if (opt) { opts.cluster_sz = opt->cluster_sz; }