From 370df805b2d51c0ceb25c107df16257ddcf32e21 Mon Sep 17 00:00:00 2001 From: John Levon Date: Tue, 26 Apr 2022 11:33:32 +0100 Subject: [PATCH] nvmf/vfio-user: remove unnecessary read barrier The spdk_rmb() in nvmf_vfio_user_poll_group_poll() is unnecessary: we already have a read barrier for SQ tail updates at the per-SQ level, so this doesn't add anything. Signed-off-by: John Levon Change-Id: I88cddd968f4a949640754526e19cb869d9fb31af Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12381 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Ben Walker --- lib/nvmf/vfio_user.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/nvmf/vfio_user.c b/lib/nvmf/vfio_user.c index 7fee75d6d..cdca3e6a0 100644 --- a/lib/nvmf/vfio_user.c +++ b/lib/nvmf/vfio_user.c @@ -5171,8 +5171,6 @@ nvmf_vfio_user_poll_group_poll(struct spdk_nvmf_transport_poll_group *group) assert(group != NULL); - spdk_rmb(); - vu_group = SPDK_CONTAINEROF(group, struct nvmf_vfio_user_poll_group, group); SPDK_DEBUGLOG(vfio_user_db, "polling all SQs\n");