From 361cddfd63b8de56ac74b50413e25f48c21a1c5d Mon Sep 17 00:00:00 2001 From: yidong0635 Date: Thu, 20 Aug 2020 05:51:06 -0400 Subject: [PATCH] nvme/nvme_pcie: Remove unused codes. pctrlr->cmb.mem_register_addr and pctrlr->cmb.mem_register_size are assigned after spdk_mem_register. if spdk_mem_register is failed , ctrlr_map_cmb hasn't been executed. they are not be used. So remove them. Signed-off-by: yidong0635 Change-Id: I3d1996eee8b5260b79c4c3e0a2e1d376da2343b7 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3856 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Changpeng Liu Reviewed-by: Aleksey Marchuk --- lib/nvme/nvme_pcie.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/nvme/nvme_pcie.c b/lib/nvme/nvme_pcie.c index 132e34cdc..4c8fb2509 100644 --- a/lib/nvme/nvme_pcie.c +++ b/lib/nvme/nvme_pcie.c @@ -613,8 +613,6 @@ nvme_pcie_ctrlr_map_io_cmb(struct spdk_nvme_ctrlr *ctrlr, size_t *size) VALUE_2MB - 1); mem_register_end = _2MB_PAGE((uintptr_t)pctrlr->cmb.bar_va + pctrlr->cmb.current_offset + pctrlr->cmb.size); - pctrlr->cmb.mem_register_addr = (void *)mem_register_start; - pctrlr->cmb.mem_register_size = mem_register_end - mem_register_start; rc = spdk_mem_register((void *)mem_register_start, mem_register_end - mem_register_start); if (rc) {