ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lib/ftl: Add error log after IO failure

Browse Source 
Adding some extra debug information for any failing IOs.

Signed-off-by: Mateusz Kozlowski <mateusz.kozlowski@intel.com>
Change-Id: If38de30bcb80d291778ad7325a33b7786d02390d
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/461588
Reviewed-by: Wojciech Malikowski <wojciech.malikowski@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Mateusz Kozlowski 2019-07-12 11:31:54 +02:00 committed by Darek Stojaczyk
parent 6b92b21d21
commit 3500d9a98d
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/ftl/ftl_io.c
View File

@ -40,6 +40,7 @@
#include "ftl_core.h" #include "ftl_core.h"
#include "ftl_rwb.h" #include "ftl_rwb.h"
#include "ftl_band.h" #include "ftl_band.h"
#include "ftl_debug.h"
void void
ftl_io_inc_req(struct ftl_io *io) ftl_io_inc_req(struct ftl_io *io)
@ -488,12 +489,18 @@ ftl_io_alloc_child(struct ftl_io *parent)
void void
ftl_io_process_error(struct ftl_io *io, const struct spdk_nvme_cpl *status) ftl_io_process_error(struct ftl_io *io, const struct spdk_nvme_cpl *status)
{ {
char ppa_buf[128];
/* TODO: add error handling for specifc cases */ /* TODO: add error handling for specifc cases */
if (status->status.sct == SPDK_NVME_SCT_MEDIA_ERROR && if (status->status.sct == SPDK_NVME_SCT_MEDIA_ERROR &&
status->status.sc == SPDK_OCSSD_SC_READ_HIGH_ECC) { status->status.sc == SPDK_OCSSD_SC_READ_HIGH_ECC) {
return; return;
} }
SPDK_ERRLOG("Status code type 0x%x, status code 0x%x for IO type %u @ppa: %s, lba 0x%lx, cnt %lu\n",
status->status.sct, status->status.sc, io->type, ftl_ppa2str(io->ppa, ppa_buf, sizeof(ppa_buf)),
ftl_io_get_lba(io, 0), io->lbk_cnt);
io->status = -EIO; io->status = -EIO;
} }