From 34cdf61f80c2ca040cd8cb030a161778fab626b1 Mon Sep 17 00:00:00 2001 From: Darek Stojaczyk Date: Mon, 22 Jul 2019 15:26:20 +0200 Subject: [PATCH] ut/nvme: add missing probe_ctx.init_ctrlrs tailq initialization Detected by scanbuild, but it's actually a programming error. It could make the failed test segfault instead of cleanly printing the total number of failures. Change-Id: I12f4bc2b1ccd2034251c1840381875d51708c6fb Signed-off-by: Darek Stojaczyk Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462871 Tested-by: SPDK CI Jenkins Reviewed-by: yidong0635 Reviewed-by: Tomasz Zawadzki Reviewed-by: Maciej Szwed Reviewed-by: Shuhei Matsumoto Reviewed-by: Ben Walker --- test/unit/lib/nvme/nvme.c/nvme_ut.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/unit/lib/nvme/nvme.c/nvme_ut.c b/test/unit/lib/nvme/nvme.c/nvme_ut.c index c266b7ea2..2468b3cdc 100644 --- a/test/unit/lib/nvme/nvme.c/nvme_ut.c +++ b/test/unit/lib/nvme/nvme.c/nvme_ut.c @@ -727,6 +727,7 @@ test_nvme_ctrlr_probe(void) void *cb_ctx = NULL; struct spdk_nvme_ctrlr *dummy = NULL; + TAILQ_INIT(&probe_ctx.init_ctrlrs); nvme_driver_init(); /* test when probe_cb returns false */