ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

log: remove SPDK_ERRLOGDUMP

Browse Source 
This macro was used in only single place and served no real
purpose.

spdk_log_dump() is more commonly used directly, so use it.

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Idea720cdee767c7c6cdc30db10003ef42b88c4a3
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4540
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Mellanox Build Bot
This commit is contained in:
Tomasz Zawadzki 2020-10-06 12:20:36 -04:00
parent 7b5d9b063d
commit 324ebbfcb9
2 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
include/spdk_internal/log.h
View File

@ -41,11 +41,4 @@
#include "spdk/log.h" #include "spdk/log.h"
#define SPDK_ERRLOGDUMP(LABEL, BUF, LEN) \
do { \
if ((LEN)) { \
spdk_log_dump(stderr, (LABEL), (BUF), (LEN)); \
} \
} while (0)
#endif /* SPDK_INTERNAL_LOG_H */ #endif /* SPDK_INTERNAL_LOG_H */

2
lib/iscsi/iscsi.c
View File

@ -4322,7 +4322,7 @@ init_login_reject_response(struct spdk_iscsi_pdu *pdu, struct spdk_iscsi_pdu *rs
static void static void
iscsi_pdu_dump(struct spdk_iscsi_pdu *pdu) iscsi_pdu_dump(struct spdk_iscsi_pdu *pdu)
{ {
SPDK_ERRLOGDUMP("PDU", (uint8_t *)&pdu->bhs, ISCSI_BHS_LEN); spdk_log_dump(stderr, "PDU", (uint8_t *)&pdu->bhs, ISCSI_BHS_LEN);
} }
/* This function is used to refree the pdu when it is acknowledged */ /* This function is used to refree the pdu when it is acknowledged */