ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

module/raid: use correct rpc error codes

Browse Source 
Change-Id: Ief4b08dd424e5e62cbedcc14cbee9168eb71fd6c
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15013
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Community-CI: Mellanox Build Bot
This commit is contained in:
Artur Paszkiewicz 2022-10-17 10:58:08 +02:00 committed by Tomasz Zawadzki
parent 4ad1ac9036
commit 3171089238
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
module/bdev/raid/bdev_raid_rpc.c
View File

@ -69,7 +69,7 @@ rpc_bdev_raid_get_bdevs(struct spdk_jsonrpc_request *request,
if (spdk_json_decode_object(params, rpc_bdev_raid_get_bdevs_decoders,
SPDK_COUNTOF(rpc_bdev_raid_get_bdevs_decoders),
&req)) {
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_PARSE_ERROR,
"spdk_json_decode_object failed");
goto cleanup;
}
@ -216,13 +216,13 @@ rpc_bdev_raid_create(struct spdk_jsonrpc_request *request,
if (spdk_json_decode_object(params, rpc_bdev_raid_create_decoders,
SPDK_COUNTOF(rpc_bdev_raid_create_decoders),
&req)) {
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_PARSE_ERROR,
"spdk_json_decode_object failed");
goto cleanup;
}
if (req.strip_size_kb == 0) {
spdk_jsonrpc_send_error_response(request, EINVAL, "strip size not specified");
spdk_jsonrpc_send_error_response(request, -EINVAL, "strip size not specified");
goto cleanup;
}
@ -347,14 +347,14 @@ rpc_bdev_raid_delete(struct spdk_jsonrpc_request *request,
if (spdk_json_decode_object(params, rpc_bdev_raid_delete_decoders,
SPDK_COUNTOF(rpc_bdev_raid_delete_decoders),
&ctx->req)) {
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_PARSE_ERROR,
"spdk_json_decode_object failed");
goto cleanup;
}
raid_bdev = raid_bdev_find_by_name(ctx->req.name);
if (raid_bdev == NULL) {
spdk_jsonrpc_send_error_response_fmt(request, ENODEV,
spdk_jsonrpc_send_error_response_fmt(request, -ENODEV,
"raid bdev %s not found",
ctx->req.name);
goto cleanup;