From 30dc6a1893bce973ee5e3614f1af911af302bc76 Mon Sep 17 00:00:00 2001 From: Jim Harris Date: Tue, 4 Sep 2018 10:05:14 -0700 Subject: [PATCH] bdev: don't output "name" when write_config_json not specified This isn't valid RPC so it needs to be removed. Bdev modules were working around this issue by defining empty write_config_json methods. Signed-off-by: Jim Harris Change-Id: I3c4c20249eadfcfb4103430f5801190b14897249 Reviewed-on: https://review.gerrithub.io/424582 Chandler-Test-Pool: SPDK Automated Test System Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Changpeng Liu --- lib/bdev/bdev.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/bdev/bdev.c b/lib/bdev/bdev.c index cc484a83d..732fac2bb 100644 --- a/lib/bdev/bdev.c +++ b/lib/bdev/bdev.c @@ -1373,10 +1373,6 @@ spdk_bdev_config_json(struct spdk_bdev *bdev, struct spdk_json_write_ctx *w) if (bdev->fn_table->write_config_json) { bdev->fn_table->write_config_json(bdev, w); - } else { - spdk_json_write_object_begin(w); - spdk_json_write_named_string(w, "name", bdev->name); - spdk_json_write_object_end(w); } }