From 307082614003e61371d7270608bc5ee43740b60b Mon Sep 17 00:00:00 2001 From: Dariusz Stojaczyk Date: Wed, 18 Oct 2017 10:56:17 +0200 Subject: [PATCH] bdev_virtio: explicitly return -1 on channel creation failure This doesn't change any behavior as queue_idx was always either 0 or -1, but makes it clear that this function always returns -1 on error. This is required by current io_channel implementation. Change-Id: I2b613ab9ff1e48d5b4aee0cd499bbc0a04cb765c Signed-off-by: Dariusz Stojaczyk Reviewed-on: https://review.gerrithub.io/382927 Reviewed-by: Jim Harris Reviewed-by: Daniel Verkamp Tested-by: SPDK Automated Test System --- lib/bdev/virtio/bdev_virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bdev/virtio/bdev_virtio.c b/lib/bdev/virtio/bdev_virtio.c index 4ea975c0e..85b6f8056 100644 --- a/lib/bdev/virtio/bdev_virtio.c +++ b/lib/bdev/virtio/bdev_virtio.c @@ -445,7 +445,7 @@ bdev_virtio_create_cb(void *io_device, void *ctx_buf) queue_idx = virtio_dev_find_and_acquire_queue(vdev, VIRTIO_SCSI_REQUESTQ); if (queue_idx < 0) { SPDK_ERRLOG("Couldn't get an unused queue for the io_channel.\n"); - return queue_idx; + return -1; } vq = vdev->vqs[queue_idx];