From 306ad7ff17b0cca75b6bacb3e9067c3523de46a4 Mon Sep 17 00:00:00 2001 From: Allen Zhu Date: Thu, 21 Jan 2021 08:38:55 +0200 Subject: [PATCH] nvme/perf: Add missing key (ns) of Transport ID in perf help NVMe namespace ID (i.e., ns) is a key of Transport ID, which is supported by perf, but it's missed in the help. In addtion, a note is added to specify multiple '-r' parameters can be used to test multiple disks/targets. Signed-off-by: Allen Zhu Change-Id: Icf55e6213a63d97396bdc7022e4c0d09c67aab9a Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6141 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Ben Walker Reviewed-by: Jim Harris Reviewed-by: Shuhei Matsumoto --- examples/nvme/perf/perf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/nvme/perf/perf.c b/examples/nvme/perf/perf.c index b3663449a..59c458920 100644 --- a/examples/nvme/perf/perf.c +++ b/examples/nvme/perf/perf.c @@ -1564,9 +1564,11 @@ static void usage(char *program_name) printf("\t traddr Transport address (e.g. 0000:04:00.0 for PCIe or 192.168.100.8 for RDMA)\n"); printf("\t trsvcid Transport service identifier (e.g. 4420)\n"); printf("\t subnqn Subsystem NQN (default: %s)\n", SPDK_NVMF_DISCOVERY_NQN); + printf("\t ns NVMe namespace ID (all active namespaces are used by default)\n"); printf("\t hostnqn Host NQN\n"); printf("\t Example: -r 'trtype:PCIe traddr:0000:04:00.0' for PCIe or\n"); printf("\t -r 'trtype:RDMA adrfam:IPv4 traddr:192.168.100.8 trsvcid:4420' for NVMeoF\n"); + printf("\t Note: can be specified multiple times to test multiple disks/targets.\n"); printf("\t[-e metadata configuration]\n"); printf("\t Keys:\n"); printf("\t PRACT Protection Information Action bit (PRACT=1 or PRACT=0)\n");