From 2f8a723edf09a645c2399735c5bfb3239b932ec7 Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Tue, 24 Jan 2023 19:40:43 +0100 Subject: [PATCH] ublk: use count in ublk_io_xmit() in release builds count was unused in release builds. Otherwise following error is produced on clang build: 19:30:56 ublk.c:974:14: error: variable 'count' set but not used [-Werror,-Wunused-but-set-variable] 19:30:56 int rc = 0, count = 0, tag; 19:30:56 ^ 19:30:56 1 error generated. Change-Id: If7ca88de37ed6e40826e09b055355c07f67c8869 Signed-off-by: Tomasz Zawadzki Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16450 Tested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Konrad Sztyber Reviewed-by: Xiaodong Liu --- lib/ublk/ublk.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/ublk/ublk.c b/lib/ublk/ublk.c index 46306fe70..8ed0cd946 100644 --- a/lib/ublk/ublk.c +++ b/lib/ublk/ublk.c @@ -993,7 +993,10 @@ ublk_io_xmit(struct ublk_queue *q) } rc = io_uring_submit(&q->ring); - assert(rc == count); + if (rc != count) { + SPDK_ERRLOG("could not submit all commands\n"); + assert(false); + } return rc; }