From 2f777920c9113447ed4ed68af6520b9e001e810d Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Mon, 3 Oct 2016 11:06:27 -0700 Subject: [PATCH] test: run more unit tests under Valgrind Where possible (for tests that don't require DPDK), run the unit tests under Valgrind to check for memory leaks and out-of-bounds accesses. Change-Id: Ic7b3cdd39a6d59f4e41b4a161be3363f6b076f65 Signed-off-by: Daniel Verkamp --- test/lib/json/json.sh | 6 +++--- test/lib/jsonrpc/jsonrpc.sh | 2 +- test/lib/log/log.sh | 2 +- test/lib/nvmf/nvmf.sh | 6 +++--- test/lib/scsi/scsi.sh | 4 ++-- test/lib/util/util.sh | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/test/lib/json/json.sh b/test/lib/json/json.sh index 25b95a954..bab687100 100755 --- a/test/lib/json/json.sh +++ b/test/lib/json/json.sh @@ -8,8 +8,8 @@ source $rootdir/scripts/autotest_common.sh timing_enter json -$testdir/parse/json_parse_ut -$testdir/util/json_util_ut -$testdir/write/json_write_ut +$valgrind $testdir/parse/json_parse_ut +$valgrind $testdir/util/json_util_ut +$valgrind $testdir/write/json_write_ut timing_exit json diff --git a/test/lib/jsonrpc/jsonrpc.sh b/test/lib/jsonrpc/jsonrpc.sh index c247afb5f..8a279b37a 100755 --- a/test/lib/jsonrpc/jsonrpc.sh +++ b/test/lib/jsonrpc/jsonrpc.sh @@ -8,6 +8,6 @@ source $rootdir/scripts/autotest_common.sh timing_enter jsonrpc -$testdir/server/jsonrpc_server_ut +$valgrind $testdir/server/jsonrpc_server_ut timing_exit jsonrpc diff --git a/test/lib/log/log.sh b/test/lib/log/log.sh index 41e06b503..af9704cb4 100755 --- a/test/lib/log/log.sh +++ b/test/lib/log/log.sh @@ -8,6 +8,6 @@ source $rootdir/scripts/autotest_common.sh timing_enter log -$testdir/log_ut +$valgrind $testdir/log_ut timing_exit log diff --git a/test/lib/nvmf/nvmf.sh b/test/lib/nvmf/nvmf.sh index 787530810..6f7fa0576 100755 --- a/test/lib/nvmf/nvmf.sh +++ b/test/lib/nvmf/nvmf.sh @@ -9,9 +9,9 @@ source $rootdir/scripts/autotest_common.sh timing_enter nvmf timing_enter unit -$testdir/request/request_ut -$testdir/session/session_ut -$testdir/subsystem/subsystem_ut +$valgrind $testdir/request/request_ut +$valgrind $testdir/session/session_ut +$valgrind $testdir/subsystem/subsystem_ut timing_exit unit timing_exit nvmf diff --git a/test/lib/scsi/scsi.sh b/test/lib/scsi/scsi.sh index fcf5ce98c..9694d47d2 100755 --- a/test/lib/scsi/scsi.sh +++ b/test/lib/scsi/scsi.sh @@ -8,9 +8,9 @@ source $rootdir/scripts/autotest_common.sh timing_enter scsi -$testdir/dev/dev_ut +$valgrind $testdir/dev/dev_ut $testdir/init/init_ut -$testdir/lun/lun_ut +$valgrind $testdir/lun/lun_ut $testdir/scsi_bdev/scsi_bdev_ut timing_exit scsi diff --git a/test/lib/util/util.sh b/test/lib/util/util.sh index 665fbd622..97eefff13 100755 --- a/test/lib/util/util.sh +++ b/test/lib/util/util.sh @@ -8,7 +8,7 @@ source $rootdir/scripts/autotest_common.sh timing_enter util -$testdir/bit_array/bit_array_ut -$testdir/io_channel/io_channel_ut +$valgrind $testdir/bit_array/bit_array_ut +$valgrind $testdir/io_channel/io_channel_ut timing_exit util