diff --git a/lib/iscsi/iscsi.c b/lib/iscsi/iscsi.c index 260ae6373..ec61e7960 100644 --- a/lib/iscsi/iscsi.c +++ b/lib/iscsi/iscsi.c @@ -2034,38 +2034,35 @@ static int spdk_iscsi_op_login_notify_session_info(struct spdk_iscsi_conn *conn, struct spdk_iscsi_pdu *rsp_pdu) { - char buf[MAX_TMPBUF]; struct spdk_iscsi_portal *portal = conn->portal; struct iscsi_bhs_login_rsp *rsph; rsph = (struct iscsi_bhs_login_rsp *) & (rsp_pdu->bhs); if (conn->sess->session_type == SESSION_TYPE_NORMAL) { /* normal session */ - snprintf(buf, sizeof buf, "Login from %s (%s) on %s tgt_node%d" - " (%s:%s,%d), ISID=%"PRIx64", TSIH=%u," - " CID=%u, HeaderDigest=%s, DataDigest=%s\n", - conn->initiator_name, conn->initiator_addr, - conn->target->name, conn->target->num, - portal->host, portal->port, portal->group->tag, - conn->sess->isid, conn->sess->tsih, conn->cid, - (spdk_iscsi_param_eq_val(conn->params, "HeaderDigest", "CRC32C") - ? "on" : "off"), - (spdk_iscsi_param_eq_val(conn->params, "DataDigest", "CRC32C") - ? "on" : "off")); - SPDK_NOTICELOG("%s", buf); + SPDK_NOTICELOG("Login from %s (%s) on %s tgt_node%d" + " (%s:%s,%d), ISID=%"PRIx64", TSIH=%u," + " CID=%u, HeaderDigest=%s, DataDigest=%s\n", + conn->initiator_name, conn->initiator_addr, + conn->target->name, conn->target->num, + portal->host, portal->port, portal->group->tag, + conn->sess->isid, conn->sess->tsih, conn->cid, + (spdk_iscsi_param_eq_val(conn->params, "HeaderDigest", "CRC32C") + ? "on" : "off"), + (spdk_iscsi_param_eq_val(conn->params, "DataDigest", "CRC32C") + ? "on" : "off")); } else if (conn->sess->session_type == SESSION_TYPE_DISCOVERY) { /* discovery session */ - snprintf(buf, sizeof buf, "Login(discovery) from %s (%s) on" - " (%s:%s,%d), ISID=%"PRIx64", TSIH=%u," - " CID=%u, HeaderDigest=%s, DataDigest=%s\n", - conn->initiator_name, conn->initiator_addr, - portal->host, portal->port, portal->group->tag, - conn->sess->isid, conn->sess->tsih, conn->cid, - (spdk_iscsi_param_eq_val(conn->params, "HeaderDigest", "CRC32C") - ? "on" : "off"), - (spdk_iscsi_param_eq_val(conn->params, "DataDigest", "CRC32C") - ? "on" : "off")); - SPDK_NOTICELOG("%s", buf); + SPDK_NOTICELOG("Login(discovery) from %s (%s) on" + " (%s:%s,%d), ISID=%"PRIx64", TSIH=%u," + " CID=%u, HeaderDigest=%s, DataDigest=%s\n", + conn->initiator_name, conn->initiator_addr, + portal->host, portal->port, portal->group->tag, + conn->sess->isid, conn->sess->tsih, conn->cid, + (spdk_iscsi_param_eq_val(conn->params, "HeaderDigest", "CRC32C") + ? "on" : "off"), + (spdk_iscsi_param_eq_val(conn->params, "DataDigest", "CRC32C") + ? "on" : "off")); } else { SPDK_ERRLOG("unknown session type\n"); /* Initiator error */